fix(people): tell same-named people apart; a history of finished runs, each with its time and run, read as the patient page reads it (#655) - #722
Merged
Conversation
added 3 commits
September 28, 2026 14:15
…ures, reads status as the patient page does, and names each row's run (#655) The history read every outcome of every run: rows from runs still going or failed, rows for measures the deployment no longer runs, and the stored MISSING_DATA where the patient page shows "Not in population". Each row now carries its run and what started it, so two evaluations on one day read as two runs rather than a duplicate. The patient page's reading is one shared helper.
…story shows each row's time, run and the patient page's status (#655) The People list was a bare name per row, and the pilot has several same-named patients. A person's history dropped the time of day and showed the stored MISSING_DATA; it now shows date and time, what ran (nightly, manual run, single-patient rerun), and "Not in population" as the patient page does. Each linked record links to its patient page.
… not today's cohort, and reads its runs in one query - displayStatus is deriveCell's reading of each row. The patient page's cohort overlay applies to the newest row only; applied to history it rewrote every past row whenever a segment or a role changed. The shared helper is reverted. - The runs behind a person's rows come from one getRunsByIds read (both stores, contract-tested) instead of one round trip per run, which grew with every nightly on a stack that never compacts. - Run labels follow Run History's vocabulary: a one-subject run is not called a rerun, a case's rerun reads "Rerun to verify", and seeded rows say they are synthetic. PARTIAL_FAILURE, CASE and SEED are covered by the test.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce1ef9745d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
added 3 commits
September 28, 2026 14:41
…f one kind in one minute still differ
…y of finished runs with each row's time and run
5 of 65 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three items from the #655 checklist, all checked on live Maui first (admin seat, 2026-09-28).
What was wrong
/peoplerendered only a name. Three rows in a row read "Adriana Aoki", with nothing to tell them apart.What changed
runIdand what started it: Nightly, Manual run, Single-patient run, Rerun to verify, or Seed (synthetic). The page shows the date and time, so two evaluations on one day read as two runs.deriveCell), so out-of-population rows read "Not in population". The patient page's cohort overlay is deliberately not applied to history, because it would rewrite every past row whenever a segment or a role changed.RunStore.getRunsByIds, which is one read in both stores and is contract-tested. It replaces one round trip per run, which grew with every nightly on a stack that never compacts.Out of scope
These stay on #655:
The journal line follows once #721 merges, to avoid a conflict in the same day's section.
Verification