Repository navigation
Fix confidentiality checks, stale fee inputs, and legacy upload recovery - #278
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files added from Review can receive a filing type automatically and skip Organize before confidentiality has been answered. This follow-up to #277 sends those files through Organize, rejects document checks from a Fees page with stale fee inputs, and gives older uploads a path through document preparation.
Changes
document_type_confirmedon each document. A blank confidentiality code counts as complete only after Organize verifies that the court offers no choices. Preserve this confirmation when rebuilding the same supporting file with unchanged filing and document types; reset it when those types or the filing path change.fee_inputs_tokenwhen confirming or removing a document. Reject stale inputs with HTTP 409 before changing the document or returning a replacement token, so another tab's case changes cannot be paired with the page's old case data.Migration
Adds migration
0030_document_type_confirmed, with a default ofFalse. Existing documents with a confidentiality code remain complete; existing blank codes need Organize to verify that the court has no choices.Validation
uv run pytest -q: 1,350 passed, 2 skipped.npm run test:unit: 71 passed.uv run ruff check .,uv run ruff format --check ., anduv run ty check: passed.uv run python manage.py makemigrations --check --dry-run: no changes detected..venv-root-owned-BROKENbackup directory excluded (npm run lint:js -- --ignore-pattern '.venv-root-owned-BROKEN/**'). The unmodified command scans that backup's third-party JavaScript and fails on unrelated files.