fix: point the Documentation nav item at the wiki - #71
Merged
Conversation
Closes #63. The "Documentation" nav item opened the README anchor (https://github.com/StuartMeeks/Snipdeck#readme). User-facing docs live in the wiki; the README is only the project intro, so the nav item now opens https://github.com/StuartMeeks/Snipdeck/wiki. The nav test asserted DocumentationUrl against itself, which would have passed whatever the constant held, so it now pins the literal wiki URL instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63.
The Documentation nav item opened the README anchor,
https://github.com/StuartMeeks/Snipdeck#readme. User-facing documentation lives in the wiki — the README is only the project intro — so it now openshttps://github.com/StuartMeeks/Snipdeck/wiki.One line of behaviour, in
ShellViewModel.DocumentationUrl. I confirmed the wiki URL resolves (HTTP 200, "Home · StuartMeeks/Snipdeck Wiki").Also
The existing nav test asserted
ShellViewModel.DocumentationUrlagainstlinks.LastOpenedUrl— comparing the constant to itself, so it would have passed whatever the nav item pointed at. It now pins the literal wiki URL, and is renamed fromOpenDocumentation_opens_the_readme_urlto..._opens_the_wiki_url.Scope
The nav item is the only place in the app that linked to documentation — Settings › About carries a clone command and an issues link, neither of which is affected. I left
README.mdalone; if you want it to cross-link to the wiki too, that is a separate docs change, happy to do it.Verification
253 Core tests pass; the WinUI head compiles clean (0 warnings) on a Windows 11 host.
🤖 Generated with Claude Code