Skip to content

Fix flaky tests - #1745

Merged
bart-vmware merged 6 commits into
mainfrom
fix-flaky-tests
Sep 24, 2026
Merged

bart-vmware merged 6 commits into
mainfrom
fix-flaky-tests

Conversation

@bart-vmware

Copy link
Copy Markdown
Member

Description

Fix flaky tests by using robust signaling instead of sleeps. On high load (typically during CI builds), async callbacks may execute much later than expected, due to a limited number of threads in the pool.

Steeltoe code itself gains a few internal events, which have no cost unless subscribed to (from tests).

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation and/or Samples, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 83.3%
Steeltoe.Common 88.4% 81.2%
Steeltoe.Common.Certificates 95.6% 84.5%
Steeltoe.Common.Hosting 83.5% 65%
Steeltoe.Common.Http 97.4% 80.9%
Steeltoe.Common.Logging 80.6% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 96.3% 89.4%
Steeltoe.Configuration.CloudFoundry 98.4% 92.7%
Steeltoe.Configuration.ConfigServer 91.6% 86.2%
Steeltoe.Configuration.Encryption 97.6% 87.8%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.6% 82.6%
Steeltoe.Configuration.Placeholder 93.8% 82.6%
Steeltoe.Configuration.RandomValue 93.2% 83.3%
Steeltoe.Configuration.SpringBoot 98.3% 85%
Steeltoe.Connectors 94.4% 85.3%
Steeltoe.Connectors.EntityFrameworkCore 81% 65.3%
Steeltoe.Discovery.Configuration 96.3% 75%
Steeltoe.Discovery.Consul 91.5% 83.8%
Steeltoe.Discovery.Eureka 90.1% 81.3%
Steeltoe.Discovery.HttpClients 89.9% 91.4%
Steeltoe.Logging.Abstractions 99.4% 95.6%
Steeltoe.Logging.DynamicConsole 100% 92.3%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 96% 87.3%
Steeltoe.Management.GitProperties.Build 95.1% 83.9%
Steeltoe.Management.Prometheus 95.8% 76.9%
Steeltoe.Management.Tasks 95.2% 80%
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 93.7%
Steeltoe.Security.Authentication.OpenIdConnect 87.7% 66.6%
Steeltoe.Security.Authorization.Certificate 96.8% 66.6%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware
bart-vmware force-pushed the fix-flaky-tests branch 2 times, most recently from cdcfb9d to 9a64ac6 Compare September 21, 2026 13:16
@bart-vmware
bart-vmware force-pushed the fix-flaky-tests branch 5 times, most recently from 109734d to 160e03a Compare September 23, 2026 15:08
@bart-vmware
bart-vmware marked this pull request as ready for review September 23, 2026 15:22
@bart-vmware
bart-vmware requested a review from TimHess September 23, 2026 15:22
Base automatically changed from update-memory-dumps to main September 23, 2026 17:15
Comment thread src/Discovery/src/Eureka/EurekaDiscoveryClient.cs Outdated
@bart-vmware
bart-vmware requested a review from TimHess September 23, 2026 22:43
@sonarqubecloud

Copy link
Copy Markdown

@bart-vmware
bart-vmware merged commit 9b21c1e into main Sep 24, 2026
651 of 653 checks passed
@bart-vmware
bart-vmware deleted the fix-flaky-tests branch September 24, 2026 08:59
@bart-vmware bart-vmware added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Sep 25, 2026
@bart-vmware bart-vmware added this to the 3.4.1 milestone Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants