Repository navigation
Expose the server logger through route dependency injection - #11
Merged
Merged
Conversation
Co-authored-by: DrewImm <30954849+DrewImm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add log instance to hidi container for routers and endpoints
Expose the server logger through route dependency injection
Oct 10, 2026
DrewImm
marked this pull request as ready for review
October 10, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routers and endpoints need access to the configured server logger through Hidi’s dependency hierarchy. Register the logger in the server container so route containers inherit it.
Container registration: Register the configured logger under
login the server’s root container.Route access: Routers and endpoints can resolve the inherited instance:
Regression coverage: Verify the router and endpoint resolve the same logger instance configured on the server.