Skip to content

Override getBooleanValue in ConfigurateOps to support DFU v10 #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Toffikk wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Override getBooleanValue in ConfigurateOps to support DFU v10 #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions extra/dfu7/src/main/java/org/spongepowered/configurate/extra/dfu/v7/ConfigurateOps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,19 @@ public DataResult<Number> getNumberValue(final ConfigurationNode input) {
return DataResult.error(() -> "Not a number: " + input);
}

/**
* Get the value of the provided node if it is a boolean or a number where non-zero is {@code true}.
*
* @param input data source
* @return extracted boolean
*/
@Override
public DataResult<Boolean> getBooleanValue(final ConfigurationNode input) {
return getNumberValue(input)
.map(number -> number.doubleValue() != 0.0)
.mapError(_ -> "Not a boolean: " + input);
}

/**
* Get the value of the provided node if it is a scalar, converted to
* a {@link String}.
Expand Down