Add premium forecast endpoints to SDK - #53
Merged
lorenzo-solcast merged 3 commits intoAug 31, 2026
Conversation
nik-solcast
force-pushed
the
feature/premium-forecast-sdk
branch
from
August 27, 2026 06:25
000b37f to
8e8325b
Compare
Read request-body schema descriptions when generating compatibility Args sections and retain the verified regenerated SDK output.
nik-solcast
force-pushed
the
feature/premium-forecast-sdk
branch
from
August 27, 2026 06:28
8e8325b to
7fd20de
Compare
Contributor
|
Changes look ok to me. Is the motivation for all the unrelated docstring changes, to get these aligned with that the automated generation approach would provide, to make it easier to use the automated generation in future? The documentation at docs/forecast.md also needs to be updated to reference the premium options. |
Collaborator
Author
|
@michaelf-solcast yes, my intention is to align with the docstring as over time the SDK tells different story from the code and no one is updating it manually. If there is value in keeping different or shorter versions in some cases, that could also be handled. |
Contributor
|
Doco looks ok. Happy to approve the changes, provision on you having tested them in python, but I don't have permission to approve (need to be maintainer?) |
Collaborator
Author
|
hugh-solcast
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds premium PV and wind forecast endpoints while preserving compatibility-mode SDK structure. Tests: 35 passed.