Skip to content

style: apply pint - #248

Merged
atymic merged 1 commit into
SocialiteProviders:masterfrom
atymic:style/apply-pint
Aug 16, 2026
Merged

atymic merged 1 commit into
SocialiteProviders:masterfrom
atymic:style/apply-pint

Conversation

@atymic

@atymic atymic commented Aug 16, 2026

Copy link
Copy Markdown
Member

Applies pint to the 10 files that the Lint workflow flagged in #247, turning that job green.

Formatting only — no behavioural changes. Every modified line is a docblock, an import, or whitespace. The fixers involved were fully_qualified_strict_types, ordered_imports, unary_operator_spaces, not_operator_with_successor_space and blank_line_after_namespace.

One manual adjustment on top of Pint's output: fully_qualified_strict_types shortens FQCNs in docblocks, and where the class was already imported under an alias it added a second import of the same class under its short name, e.g.

use Illuminate\Contracts\Container\Container;
use Illuminate\Contracts\Container\Container as Application;

Rather than keep the duplicate, those docblocks now reference the existing alias. Affected SocialiteWasCalled, both Contracts\*\ProviderInterfaces and ManagerTestTrait. pint --test passes with these in place.

Verified: pint --test passes, 28 tests / 62 assertions pass, php -l clean across src/ and tests/.

Formatting only. No behavioural changes: every modified line is a
docblock, an import or whitespace.

Where the fully_qualified_strict_types fixer shortened a docblock that
referenced a class already imported under an alias, the docblock now
uses that alias rather than adding a second import of the same class.
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.72%. Comparing base (a67f194) to head (00d68f4).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #248      +/-   ##
============================================
+ Coverage     55.10%   56.72%   +1.62%     
- Complexity       78       79       +1     
============================================
  Files            10       10              
  Lines           245      238       -7     
============================================
  Hits            135      135              
+ Misses          110      103       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atymic
atymic merged commit 85081f6 into SocialiteProviders:master Aug 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant