style: apply pint - #248
Merged
Merged
Conversation
Formatting only. No behavioural changes: every modified line is a docblock, an import or whitespace. Where the fully_qualified_strict_types fixer shortened a docblock that referenced a class already imported under an alias, the docblock now uses that alias rather than adding a second import of the same class.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
============================================
+ Coverage 55.10% 56.72% +1.62%
- Complexity 78 79 +1
============================================
Files 10 10
Lines 245 238 -7
============================================
Hits 135 135
+ Misses 110 103 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies
pintto the 10 files that theLintworkflow flagged in #247, turning that job green.Formatting only — no behavioural changes. Every modified line is a docblock, an import, or whitespace. The fixers involved were
fully_qualified_strict_types,ordered_imports,unary_operator_spaces,not_operator_with_successor_spaceandblank_line_after_namespace.One manual adjustment on top of Pint's output:
fully_qualified_strict_typesshortens FQCNs in docblocks, and where the class was already imported under an alias it added a second import of the same class under its short name, e.g.Rather than keep the duplicate, those docblocks now reference the existing alias. Affected
SocialiteWasCalled, bothContracts\*\ProviderInterfaces andManagerTestTrait.pint --testpasses with these in place.Verified:
pint --testpasses, 28 tests / 62 assertions pass,php -lclean acrosssrc/andtests/.