chore(ci): bump Go toolchain to 1.26 - #108
Merged
Merged
Conversation
The toolchain version lives only in mise.toml since the mise migration, so this is a one-line change. Deliberately NOT touching the `go` directive in go.mod — that declares the minimum language version for consumers of the published module, and raising it would break them. Verified: go build/vet/test and gofmt all pass on 1.26. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
…something The Go 1.26 PR on this branch went green having compiled nothing: the change-gate filters list only per-language directories, and mise.toml is in none of them, so every lane skipped. A toolchain bump is the one change that affects all six lanes and the one change that triggered zero of them — the exact false green the gate exists to prevent. Adding mise.toml to each filter costs nothing on normal PRs (it is rarely touched) and makes a toolchain PR actually exercise the toolchain. publish.yml is unaffected — it has no path filters and always runs the full matrix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Bump the Go toolchain to 1.26
Since the mise migration the version lives only in
mise.toml, so this is a one-line change.Deliberately not touching the
godirective in anygo.mod(orgo/go.work) — that declares the minimum language version for consumers of the published modules, and raising it would break them.Verified locally on go1.26.7, every module CI loops over (
for m in . fiber gin), with-count=1to match CI:go build ./...go vet ./...go test -count=1 ./...gofmt -l .go/ok github.com/SmooAI/observability/go 3.464sgo/fiberok github.com/SmooAI/observability/go/fiber 0.283sgo/ginok github.com/SmooAI/observability/go/gin 0.385sscripts/check-go-modules.shalso passes (exit 0): no replace directives, module paths match directories,/vNsuffix matches major 0.No Go 1.26 incompatibilities found.
2. Fix the paths-filter that made commit 1 a false green
The first commit's CI run reported success having compiled nothing. The
changesgate filters on per-language directories, andmise.tomlwas in none of them — sogo,rust,python,dotnet,desktopandtsall skipped. A toolchain bump is the one change that affects every lane and the one change that triggered none of them.Second commit adds
mise.tomlto all six filters. Costs nothing on normal PRs (rarely touched), and makes a toolchain PR actually exercise the toolchain.publish.ymlis unaffected — it has no path filters and always runs the full matrix.🤖 Generated with Claude Code
https://claude.ai/code/session_013YaefW6U442PHZf94fMAer