🦋 New version release - #101
Merged
Merged
Conversation
brentrager
added a commit
that referenced
this pull request
Aug 20, 2026
…thout it) (#102) #99 added `scripts/sync-versions.mjs` and the package.json `version` script, but not the one input that makes the action run it. `changesets/action@v1` runs `changeset version` ITSELF unless given a `version:` command — and npm lifecycle hooks fire on `npm version`, never on `changeset version`. So the script sat there unexecuted. The next two releases proved it: #100 and #101 bumped `packages/core/package.json` to 0.19.2 while the other eleven version-bearing files stayed at 0.19.0, which is exactly what the new `versions` lane is for — it has been red on `main` since #101. Two changes: - `version: pnpm run version` on the changesets action, so the hook actually runs and the action commits the synced files into the release commit. `pnpm run version`, not `pnpm version` — the latter is pnpm's own builtin and would not run the script. - Sync all eleven files up to 0.19.2, catching main back up. No changeset on purpose. Adding one would bump to 0.19.3 and re-open the drift this commit is closing; the sync is mechanical catch-up, not a behavior change beyond the one #99 already described. From here the hook keeps them in step without anyone remembering to. Claude-Session: https://claude.ai/code/session_0152bbE1veqfG1SVJdyLCBxC Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@smooai/observability@0.19.2
Patch Changes
bdd092f: Every event this SDK has ever sent reported
sdk.version: "0.1.0".packages/core/src/client.tshard-codedSDK_VERSION = '0.1.0'while the published package walked from 0.1.0 to 0.19.0. Eighteen minor releases of events landed in the backend labelled with the version of the first one, so "which SDK version produced this event?" — the question the field exists to answer — has been unanswerable for the entire life of the package. The Rust, Python, Go and .NET ports all carried the same frozen constant.The constant is now derived, not typed.
scripts/sync-versions.mjstreatspackages/core/package.jsonas the single source of truth and writes it into all eleven version-bearing files across the five SDKs — manifests (Cargo.toml,pyproject.toml,.csproj), lockfiles (Cargo.lock,uv.lock), and the reported-version constants in each language.It runs in the changesets
versionlifecycle, not after publish:That ordering is the fix, not a detail. The changesets action commits the working tree after
version, so the synced files land in the release commit and every tag carries the versions it claims. Syncing afterpublish— the pattern in the sibling repos — mutates manifests in a CI workspace that is never committed, which is why those repos needcargo publish --allow-dirtyto paper over the dirt.A
--checkmode runs on every PR (pr-checks.yml, deliberately not path-filtered) and fails on any mismatch. ATARGETSrow whose pattern matches zero times, or more than once, is a hard error too — a silently-skipped target is the exact failure this script exists to prevent.One version across languages is the org's existing convention, not a new invention:
@smooai/fetchis 3.4.1 on npm, crates.io and PyPI alike. The four unreleased SDKs are therefore set to 0.19.0 rather than starting over at 0.1.0.