chore: delete .nvmrc — mise.toml is the toolchain pin now - #119
Merged
Conversation
The mise migration moved the Node version into mise.toml, but left .nvmrc behind still pinning v22.14.0. That is not inert: mise reads idiomatic version files when `idiomatic_version_file_enable_tools` includes node, and when it does, .nvmrc WINS over mise.toml. A developer with that setting silently got Node 22.14.0 while CI built on 24.14.0 — the exact local/CI split the migration existed to remove. CI was never affected (the runner has no such setting, so mise-action used mise.toml), which is why this was invisible in every green run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013YaefW6U442PHZf94fMAer
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mise migration moved the Node pin into
mise.tomlbut left.nvmrcbehind, still pinning v22.14.0.That is not inert. mise reads idiomatic version files when
idiomatic_version_file_enable_toolsincludesnode, and when it does.nvmrcwins overmise.toml:So a developer with that setting silently got Node 22.14.0 while CI built on 24.14.0 — precisely the local/CI split this migration existed to remove.
CI was never affected: the runner has no such setting, so
mise-actioncorrectly usedmise.toml. That is why every green run hid this.🤖 Generated with Claude Code
https://claude.ai/code/session_013YaefW6U442PHZf94fMAer