Repository navigation
Expect DC current fields in kA - #73
luke-kiernan wants to merge 2 commits into
Conversation
Follows Sienna-Platform/SiennaSchemas#94, which declares the DC current fields in kA. The parser keeps reading PSS/E's A and its unit-aware `set_value!` converts to the declared unit, so only the expectations change. These pass once PowerOpenAPIModels is regenerated against #94. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Open question for review: what value means "no DC current limit"? The stack currently uses two different "infinities" for these currents, and moving the fields from A to kA makes them diverge further:
So:
Nothing in this set changes these values. Whatever is decided, it's about a one-line change each in the schema, PSY, PFFP and PF. |
|
The tests-only approach checks out: every current field goes through 1. RAW
2. Stale docstring. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rodrigomha
left a comment
There was a problem hiding this comment.
All addressed, thanks. Approving. The remaining failures, including the new IMAX = 0 test (9.999e6), clear once PowerOpenAPIModels is regenerated with kA.
Warning
These tests fail until PowerOpenAPIModels is regenerated against Sienna-Platform/SiennaSchemas#94 and released. The conversion is driven by the models' declared units (
IC.has_declared_unit). Merge together with the rest of the A→kA set (Sienna-Platform/PowerSystems.jl#1836).Summary
No source changes, just tests. The parser keeps reading PSS/E's currents in A (
set_value!(component, :dc_current, d["if"], "A")), and its unit-awareset_value!converts to whatever unit the schema declares. Once the schema declares kA, the parser stores kA, and the PSS/E-native dict stays in A. So we need an extra factor of 1000 in a few places.The A→kA set
Sienna-Platform/SiennaSchemas#94 → PowerOpenAPIModels regeneration → Sienna-Platform/PowerSystems.jl#1836, this PR, and consumer updates in PowerFlows.jl, PowerOperationsModels.jl and PowerSystemCaseBuilder.jl.
🤖 Generated with Claude Code