feat(error): stabilize error classification priority - #154
Merged
0x676e67 merged 4 commits intoAug 3, 2026
Merged
Conversation
0x676e67
force-pushed
the
demo/stabilize-error-classification-order-111
branch
from
July 31, 2026 07:24
1a89b70 to
9f8d3b2
Compare
…e-error-classification-111
BREAKING CHANGE: Wreq::ConnectionError and Wreq::ProxyConnectionError are replaced by Wreq::ConnectError and Wreq::ProxyConnectError. The connection? and proxy_connection? predicates are replaced by connect? and proxy_connect?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Ruby exception selection deterministic when a wreq error reports overlapping native details. Native error kinds keep their own class. Request errors use this priority: connection reset, timeout, proxy connect, then connect. Every matching detail remains available through predicate methods.
This is a breaking change. The public names now follow wreq's connect-stage terminology:
Wreq::ConnectionErrorbecomesWreq::ConnectErrorWreq::ProxyConnectionErrorbecomesWreq::ProxyConnectErrorconnection?becomesconnect?proxy_connection?becomesproxy_connect?ConnectionResetErrorandconnection_reset?keep their names because they describe a reset event rather than the connect phase. The old names are removed, so callers need to update rescue clauses and predicate checks.The Ruby API docs now explain connect, proxy connect, timeout, and reset overlap. The complete Ruby and Rust test suites, Clippy, Rustfmt, and StandardRB pass on Windows GNU.