Skip to content

Hold TypeScript at 5.9 so npm ci keeps resolving - #91

Closed
vpetersson-bot wants to merge 1 commit into
mainfrom
chore/hold-typescript-at-6
Closed

vpetersson-bot wants to merge 1 commit into
mainfrom
chore/hold-typescript-at-6

Conversation

@vpetersson-bot

Copy link
Copy Markdown
Contributor

Every job on the monthly npm bump fails at npm ci:

npm error ERESOLVE could not resolve
npm error While resolving: typescript-eslint@8.70.1
npm error Found: typescript@7.0.2
npm error peer typescript@">=4.8.4 <6.1.0" from typescript-eslint@8.70.1

typescript-eslint caps its typescript peer at <6.1.0, and its latest release
still does — TypeScript 7 removed ts.Extension.Cjs, which
@typescript-eslint/typescript-estree reads at load time. Until typescript-eslint
ships TypeScript 7 support there is no version of this repo that can take the bump.

This takes the rest of the bump (@sentry/browser 11, jsdom 30, vitest 5,
globals 17, @types/node 26) and leaves typescript on ^5.9.3, plus a
dependabot ignore entry so TypeScript 7 is not proposed again. Drop the ignore
entry once typescript-eslint supports it.

Verified on Node 24: npm run lint, npm run format:check, npm run type-check,
npm run build and npm test (22 files, 204 tests) all pass.

🤖 Generated with Claude Code

typescript-eslint caps its typescript peer at <6.1.0, so bumping typescript to 7
makes npm ci fail with ERESOLVE and every CI job dies before it starts.

Take the rest of the bump, keep typescript on ^5.9.3, and tell dependabot to
skip TypeScript 7 until typescript-eslint supports it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 4, 2026 09:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

jsdom 30 and Vitest 5 conflict with the package’s advertised Node 20 support.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Keeps TypeScript on 5.9 while updating other npm dependencies.

Changes:

  • Upgrades Sentry, jsdom, Vitest, Node types, and globals.
  • Regenerates the npm lockfile.
  • Prevents Dependabot from proposing TypeScript 7.
File Description
package.json Updates dependency versions.
package-lock.json Locks updated dependency trees.
.github/​dependabot.yml Ignores TypeScript 7 updates.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
"eslint": "^10.0.3",
"jiti": "^2.6.1",
"jsdom": "^28.1.0",
"jsdom": "^30.1.1",
@vpetersson-bot

Copy link
Copy Markdown
Contributor Author

Closing this as a duplicate — an equivalent change (same TypeScript holdback plus the
dependabot ignore entry) was already opened on 2026-09-29 and is green. Review that
one instead.

@vpetersson-bot
vpetersson-bot deleted the chore/hold-typescript-at-6 branch October 4, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants