Repository navigation
Hold TypeScript at 5.9 so npm ci keeps resolving - #91
Closed
vpetersson-bot wants to merge 1 commit into
Closed
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
typescript-eslint caps its typescript peer at <6.1.0, so bumping typescript to 7 makes npm ci fail with ERESOLVE and every CI job dies before it starts. Take the rest of the bump, keep typescript on ^5.9.3, and tell dependabot to skip TypeScript 7 until typescript-eslint supports it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
jsdom 30 and Vitest 5 conflict with the package’s advertised Node 20 support.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Keeps TypeScript on 5.9 while updating other npm dependencies.
Changes:
- Upgrades Sentry, jsdom, Vitest, Node types, and globals.
- Regenerates the npm lockfile.
- Prevents Dependabot from proposing TypeScript 7.
| File | Description |
|---|---|
package.json |
Updates dependency versions. |
package-lock.json |
Locks updated dependency trees. |
.github/dependabot.yml |
Ignores TypeScript 7 updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "eslint": "^10.0.3", | ||
| "jiti": "^2.6.1", | ||
| "jsdom": "^28.1.0", | ||
| "jsdom": "^30.1.1", |
Contributor
Author
|
Closing this as a duplicate — an equivalent change (same TypeScript holdback plus the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Every job on the monthly npm bump fails at
npm ci:typescript-eslintcaps its typescript peer at<6.1.0, and its latest releasestill does — TypeScript 7 removed
ts.Extension.Cjs, which@typescript-eslint/typescript-estreereads at load time. Until typescript-eslintships TypeScript 7 support there is no version of this repo that can take the bump.
This takes the rest of the bump (
@sentry/browser11,jsdom30,vitest5,globals17,@types/node26) and leavestypescripton^5.9.3, plus adependabot
ignoreentry so TypeScript 7 is not proposed again. Drop theignoreentry once typescript-eslint supports it.
Verified on Node 24:
npm run lint,npm run format:check,npm run type-check,npm run buildandnpm test(22 files, 204 tests) all pass.🤖 Generated with Claude Code