Repository navigation
fix(deps): hold typescript below 7 until typescript-eslint supports it - #86
Closed
vpetersson-bot wants to merge 1 commit into
Closed
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
typescript-eslint has no released version that supports TypeScript 7 -- even 8.70.0 declares a peer range of `typescript >=4.8.4 <6.1.0`. With TS 7 in the group, `npm ci` fails with ERESOLVE and every CI job fails with it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Duplicate of #85, which already proposes the same fix. Closing this one in favour of the earlier PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The weekly
npmgroup PR (#84) is red on all four jobs — Build, Format, Lint and Test. They all fail at the same place,npm ci:Cause
typescript-eslinthas no released version that supports TypeScript 7. Every published version up to and including the current8.70.0declares:So bumping
typescript-eslintdoes not help — the group simply cannot taketypescript7 yet. Install fails, and every job downstream of it fails with it.For the record, the runtime symptom if you force the install past npm is
TypeError: Cannot read properties of undefined (reading 'Cjs')in@typescript-eslint/typescript-estree— TypeScript 7 no longer exposesExtensionon its public API.Fix
Have Dependabot hold
typescriptbelow 7 untiltypescript-eslintsupports it. The rest of the group keeps flowing, includingtypescript6.Verification
Checked out #84 locally with
typescriptdropped to^6.0.3and every other update in the group kept:One follow-up, not fixed here
Once the install is unblocked, the
Formatjob will still fail. Prettier 3.9.6 (also in this group) reformats one union type insrc/utils/calendar.ts:That reformat has to land in the same commit as the Prettier bump — 3.8.1 and 3.9.6 reject each other's output, so committing it here would turn
mainred instead. Runnpm run formatinside the regenerated group PR.After merging
Comment
@dependabot recreateon #84 — it will come back without thetypescriptbump.The same TypeScript 7 breakage affects all 17 Screenly edge apps; an equivalent change is going up in each.
🤖 Generated with Claude Code