Skip to content

fix(deps): hold typescript below 7 until typescript-eslint supports it - #86

Closed
vpetersson-bot wants to merge 1 commit into
mainfrom
fix/dependabot-hold-typescript-7
Closed

vpetersson-bot wants to merge 1 commit into
mainfrom
fix/dependabot-hold-typescript-7

Conversation

@vpetersson-bot

Copy link
Copy Markdown
Contributor

Problem

The weekly npm group PR (#84) is red on all four jobs — Build, Format, Lint and Test. They all fail at the same place, npm ci:

npm error code ERESOLVE
npm error While resolving: typescript-eslint@8.69.0
npm error Found: typescript@7.0.2
npm error   typescript@"^7.0.2" from the root project

Cause

typescript-eslint has no released version that supports TypeScript 7. Every published version up to and including the current 8.70.0 declares:

"peerDependencies": { "typescript": ">=4.8.4 <6.1.0" }

So bumping typescript-eslint does not help — the group simply cannot take typescript 7 yet. Install fails, and every job downstream of it fails with it.

For the record, the runtime symptom if you force the install past npm is TypeError: Cannot read properties of undefined (reading 'Cjs') in @typescript-eslint/typescript-estree — TypeScript 7 no longer exposes Extension on its public API.

Fix

Have Dependabot hold typescript below 7 until typescript-eslint supports it. The rest of the group keeps flowing, including typescript 6.

Verification

Checked out #84 locally with typescript dropped to ^6.0.3 and every other update in the group kept:

tsc --noEmit   ✓
eslint .       ✓

One follow-up, not fixed here

Once the install is unblocked, the Format job will still fail. Prettier 3.9.6 (also in this group) reformats one union type in src/utils/calendar.ts:

 type CalendarViewElement =
-  | WeeklyCalendarView
-  | DailyCalendarView
-  | ScheduleCalendarView
+  WeeklyCalendarView | DailyCalendarView | ScheduleCalendarView

That reformat has to land in the same commit as the Prettier bump — 3.8.1 and 3.9.6 reject each other's output, so committing it here would turn main red instead. Run npm run format inside the regenerated group PR.

After merging

Comment @dependabot recreate on #84 — it will come back without the typescript bump.

The same TypeScript 7 breakage affects all 17 Screenly edge apps; an equivalent change is going up in each.

🤖 Generated with Claude Code

typescript-eslint has no released version that supports TypeScript 7 --
even 8.70.0 declares a peer range of `typescript >=4.8.4 <6.1.0`. With
TS 7 in the group, `npm ci` fails with ERESOLVE and every CI job fails
with it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 13, 2026 08:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vpetersson-bot

Copy link
Copy Markdown
Contributor Author

Duplicate of #85, which already proposes the same fix. Closing this one in favour of the earlier PR.

@vpetersson-bot
vpetersson-bot deleted the fix/dependabot-hold-typescript-7 branch September 13, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants