Repository navigation
build-chain-draft: first citation takes the drafted DOI; a non-DOI stops the build - #42
Merged
Merged
Conversation
…ops the build The first citation's URL was always taken from CITATION.cff, whatever the 06_citation draft said. A question-rooted chain whose first citation is 'extends <another chain's Outcome>' was therefore pre-filled as 'extends <the paper>', silently. Now a drafted DOI is used as written; the skeleton placeholder still falls back to the CITATION.cff paper; anything that is not a DOI stops the build with a message pointing to 'Additional citations', where links to other works such as nanopublications belong. The skeleton says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-chain-draftalways took the first citation's URL fromCITATION.cff, ignoring what06_citation.mdsays. For a question-rooted chain whose first citation wasextends → <another chain's Outcome>, the wizard was pre-filled withextends → <the paper>, without any message (found while publishing the Logroño room-to-green chain).https://doi.org/{{PAPER_DOI}}) still falls back to theCITATION.cffpaper, so paper-rooted chains are unchanged.06_citation.mdskeleton states the rule.Tests: two new cases (drafted DOI wins; non-DOI stops the build); full suite 174 passed.