Move inbound translation from RoutingService to ConversationService.S… - #1401
Merged
iceljc merged 2 commits intoAug 19, 2026
Merged
Conversation
…endMessage TranslateInboundMessage was called from both InstructDirect and InstructLoop, leaving the two routing paths to stay in sync by hand. SendMessage is the only caller of either, so run it once there, ahead of the conversation hook loop. Running before the hooks means they now evaluate English content, which matters for RoutingConversationHook: it embeds message.Content and classifies intent against an English-trained model. It also means a hook can overwrite Content after SecondaryContent has been set to the user's original text. Consumers render SecondaryContent in preference to Content, so a rate-limited or intent-templated reply would be replaced by the user's own message on its way back to them. Clear SecondaryContent when a hook rewrites Content, gated on whether translation actually ran so we only ever clear a value we set ourselves. This matches RoleDialogModel.From, which already drops SecondaryContent when it replaces Content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…endMessage
TranslateInboundMessage was called from both InstructDirect and InstructLoop, leaving the two routing paths to stay in sync by hand. SendMessage is the only caller of either, so run it once there, ahead of the conversation hook loop.
Running before the hooks means they now evaluate English content, which matters for RoutingConversationHook: it embeds message.Content and classifies intent against an English-trained model.
It also means a hook can overwrite Content after SecondaryContent has been set to the user's original text. Consumers render SecondaryContent in preference to Content, so a rate-limited or intent-templated reply would be replaced by the user's own message on its way back to them. Clear SecondaryContent when a hook rewrites Content, gated on whether translation actually ran so we only ever clear a value we set ourselves. This matches RoleDialogModel.From, which already drops SecondaryContent when it replaces Content.