Repository navigation
feat: minestom server and plugin api - #435
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…strap - integrate gremlin for managing dependencies at runtime - implement bootstrap logger for library installation feedback - update build configuration to include gremlin runtime and related dependencies - add gremlin gradle plugin for enhanced dependency handling
- update documentation to clarify that surf modules are included in the server jar - specify that third-party libraries are downloaded instead of being shaded
…ncies support - change version from 2.2.1-PR435 to 2.2.2 in build.gradle.kts - update version from 3.46.1-PR435 to 3.47.0 in gradle.properties - add support for plugin dependencies in MinestomServerSurfExtension - enhance plugin loading mechanism in PluginManagerImpl and PluginsFeature
Contributor
Author
|
gecko läuft jetzt als proof of concept auf dem system |
Contributor
|
👋 TheBjoRedCraft your PR is conflicting and needs to be updated to be merged |
- update minestom-server and minestom-testing versions to experimental 26_3-SNAPSHOT - exclude net.minestom group from npc dependency - add minestom snapshots repository to build.gradle.kts
- update Minestom dependency to 26_3-SNAPSHOT - add experimental snapshot repository for Minestom 26.3 builds
Contributor
|
👋 TheBjoRedCraft your PR is conflicting and needs to be updated to be merged |
Contributor
|
👋 TheBjoRedCraft your PR is conflicting and needs to be updated to be merged |
…-server-api # Conflicts: # gradle.properties # surf-api-gradle-plugin/build.gradle.kts
twisti-dev
self-requested a review
October 16, 2026 10:35
…nization - introduce InstrumentationMixinService and IGlobalPropertyService for mixin management - implement EntityTrackerEntryDuck and ConnectionManagerDuck for entity tracking - add NpcDisplaySync to optimize NPC display updates - create mixin configurations for NPC and entity tracking features - update build.gradle.kts to include new dependencies for mixins
- add detailed descriptions for methods in EventRegistrar, MannequinNpcBuilder, and PlayerFlightListener - improve readability of comments in PlayerJoinEvent and PlayerQuitEvent - enhance understanding of functionality in various event-related classes
- update chatSpamThresholdSeconds to allow disabling the check by setting it to 0 or less - modify isIncrementAndUnderThreshold to accommodate the new threshold logic - add TickThrottlerTest to validate new threshold behavior
…nnotation - update internal API annotations across multiple files to use InternalSurfApi - ensure consistency in marking internal API elements
…mmands and plugins - runtime: publish the inventory loader only after registration, roll back a failed start, guard every shutdown step, clear the current runtime in finally and make shutdown atomic - runtime: guard core enable, log late mixin failures, set the mixin agent's installed flag only after success - runtime: discard a rejected CommandAPI platform and restore the previous one - player events: register admission as a standalone global listener; key configuration futures by Player instead of UUID - signed chat: create chat session holders on first spawn, reset them when a player re-enters configuration, and skip broadcasts once the sender has left - signed chat: apply vanilla command signature rules (reject unsigned commands under enforceSecureProfile, report signature mismatches instead of kicking, count spam on all paths) and send player chat only to recipients with FULL chat visibility - signed chat: use Minestom's DeleteChatPacket, remove the custom packet override stack and the unused outbound signing code - commands: declare command arguments as greedy strings, apply subcommand permissions to the subcommand literal, reject sibling path conflicts at registration - commands: filter tab-complete suggestions with canUse, split namespaced labels like execution does, answer failed suggestion futures, grant permissions to ServerSender - commands: drop dead-end prefix nodes from declared trees, remove the declaration cache, rebuild the dispatcher lazily and route default-value failures to the executor handler - arguments: quote string suggestions with escapeIfRequired, format decimals without scientific notation, use the parsed MiniMessage value, honor nullable types in get - arguments: validate MultiLiteralArgument/EnumArgument values at construction and reject Literal or SignedMessage bases for custom arguments - suggestions: stop failing providers from cancelling siblings or throwing - executors/events: treat a listener's or executor's own timeout as a failure - selectors: add @n, type=#tag and x_rotation/y_rotation, use bounding-box volume checks, sort around the x/y/z origin, reject negative distance/level ranges, skip dead entities - parsers: round time values and reject overflow, reject over-wide UUID groups - visibility: create the handler during configuration or on first use, check Player identity on removal and close removed handlers - coroutines: return nullable results from asyncSuspend, fail fast in withEntity for removed or instance-less entities - highlights/npc: track pending highlight placement, attach one process-wide NPC node on load and detach it on disable - tick mixin: keep running the scheduler of entities whose ticking is disabled - plugins: skip enabling plugins whose hard dependency failed, ignore optional edges in the load order, close class loaders of failed plugins, set the thread context class loader - bootstrap: propagate optionality to transitive requirements of optional plugins, skip plugin jars without a valid id, append libraries in sorted order - gradle: resolve the runServer toolchain launcher in doFirst - tests: nest platform cleanup in finally blocks, add a 2-minute default JUnit timeout, use an independent oracle for viewer lookup tests, remove the NPC test order dependency BREAKING CHANGE: sibling path conflicts, MultiLiteralArgument/EnumArgument values outside brigadier's unquoted character set, custom arguments over Literal or SignedMessage bases, negative selector ranges and over-wide UUID groups now throw; unsigned commands with signable arguments are rejected under enforceSecureProfile; withEntity on a removed entity throws; brigadier's ENABLE_COMMAND_STACK_TRACES is disabled process-wide
…48.0 in gradle.properties
…nd patch application - add pre-build command to initialize submodules recursively - set git author information for patch application in vendor directory - update comments to clarify CI build requirements for LuckPerms feature
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.