Merge main into feature/preventMultipleSetupRecords - #225
Closed
github-actions[bot] wants to merge 14 commits into
Closed
github-actions[bot] wants to merge 14 commits into
github-actions[bot] wants to merge 14 commits into
Conversation
Adds improvements to setup flow that were initially part of PR #189
Signed-off-by: DKeatonDC <165526945+DKeatonDC@users.noreply.github.com>
Signed-off-by: DKeatonDC <165526945+DKeatonDC@users.noreply.github.com>
Prepare for packaging
Signed-off-by: DKeatonDC <165526945+DKeatonDC@users.noreply.github.com>
…ribeSetup Limits Creation of Unsubscribe Record to 1
The two HTML sample templates cannot deploy as unmanaged metadata via
unpackaged/post. They reference the packaged Visualforce component across
a namespace boundary, and the component attribute recipientId is not
access="global". The platform rejects the cross-namespace call:
Cannot use attribute recipientid without global access in a
component/page that is not in the same namespace as the component
Remove:
- Unsubscribe_Contact_Template_HTML.email (+ meta)
- Unsubscribe_Lead_Template_HTML.email (+ meta)
Keep the plain-text sample. Add the CumulusCI namespace token so the
merge field resolves in both managed and unmanaged contexts:
{!Recipient.%%%NAMESPACE%%%Unsubscribe_Url_Plain_Text__c}
With this change the install path deploys clean. HTML sample delivery is
left as a product decision (see follow-up on #217).
…lates Drop HTML sample email templates from unpackaged/post
Signed-off-by: DKeatonDC <165526945+DKeatonDC@users.noreply.github.com>
…ents Improvements to Setup Flow
coriobriensfdo
approved these changes
Aug 17, 2026
Contributor
|
@coriobriensfdo This keeps creating problems and I don't think we need it anymore. I propose deleting the branch. |
Contributor
|
Deleted @coriobriensfdo |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was automatically generated because an automated merge hit a merge conflict