fix absolute tolerance for solvers - #375
Open
Fuad-HH wants to merge 2 commits into
Open
Conversation
it helps converge fields of very small magnitude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using pcms with XGC and the projected values were incorrect since the real values were less than this tolerance. For example, the temperature is field shown here is wrong because internally, it is represented in the unit
Jand the values are about 1e-19.I have changed this to 1e-50 because petsc uses this as the default values for its solvers. Ref [here].(https://petsc.org/release/manual/ksp/#:~:text=The%20user%20can%20retain,%2Dksp_max_it%20maxit.)
I will rebase this branch onto master when my other pull request gets merged: #374.
Note that there are other tolerances too. I guess they also need to be fixed, for example the interpolation ones. @abhiyanpaudel, @jacobmerson, could you let me know if I should fix them or not.