Repository navigation
Fix editor auto-close loops and slow desktop update retries - #45
Merged
Merged
Conversation
JamieW105
changed the title
JamieW105
marked this pull request as ready for review
October 21, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A queued update close request previously applied to every subsequently opened editor. New windows now ignore requests that predate their launch; windows already participating preserve the same request identity. Legacy tag-only requests are ignored.
A requested update blocked by a remaining Rustic process cancels its close request after two minutes and restores closed windows and projects using the installed version. Setup continues waiting safely for processes to exit. Logs identify blocking process names and IDs. Verified cached installers are reused after size/SHA-256 validation, and PowerShell download progress rendering is disabled to avoid its download overhead.
The title-bar Update button is also reduced to 56×16 points with smaller text and padding. Caption controls no longer expand the 24-point title bar under the application's larger button style.
Validation: updater regression suite (cache reuse/corruption, wait deferral, process logging, successful/failed Setup, project restoration), Rust update coordination tests (newly opened windows, shared requests, legacy/malformed markers), desktop layout/click tests, Clippy with warnings denied, and Windows-target platform compilation passed locally. All Windows/Linux CI checks passed, including full workspace tests, rendering and application startup smoke tests. Windows PowerShell updater regressions and packaged Setup checks passed. A fresh
dist/RusticGameEngine-Setup-0.1.0-x64-20261021-083314.exewas built and uploaded in CI run 39568762588.Companion website documentation: Rustic-Game-Engine/docs#55