Repository navigation
feat: regenerate for multi-entity step 2 (create_entity, entity_id, combined statement) - #239
Merged
Merged
Conversation
create_entity and CreateEntityRequest; entity_id on the close, setup, report, event block and live statement requests; consolidated on the live statement with entity_id and combined_entity_ids on its response; ownership_pct on the entity; the GraphQL schema snapshot with entityId on the ledger reads. The generated tier follows the API's two moves: api.graphs.select_graph leaves now that the endpoint set_selected_graph replaced is gone, and validate_schema sits under api.graphs with its tag. Release notes for v2.8.0 name both. Claude-Session: https://claude.ai/code/session_01BY3uYE5zMjjFHnjiZfiJu8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated client for the API's multi-entity step (robosystems #1714, with the two surface moves of #1708 and #1715). A graph is one reporting group, and every ledger operation can now name which entity of it to act on. Shipping ahead of the production release: every new field is optional and defaults server-side, and the one removed call already met a 404 on the API.
Changes
api/andmodels/(just generate-sdkagainst the current backend):api.robo_ledger_setup.create_entitywithCreateEntityRequest;entity_idas a new optional field on the close, setup, report, event-block and live-statement request models;consolidatedonLiveFinancialStatementRequestwithentity_id,consolidatedandcombined_entity_idson its response;ownership_pctonLedgerEntityResponse;entity_idonFiscalCalendarResponseandReportResponse. Sync and async paths are both generated.api.graphs.select_graphis gone (the API removed the endpointset_selected_graphreplaced);validate_schemamoved fromapi.schematoapi.graphswith its tag.entityIdon the ledger reads,ownershipPctonLedgerEntity,entityIdonLedgerSummary).just generate-graphqlis clean against it: the checked-in operations use none of the new arguments yet, sographql/generated/has no diff.clients/): untouched. None wrappedselect_graphorvalidate_schema..github/release-notes/v2.8.0.mdnames the removal and the path move, as the policy requires before the release dispatch.Compatibility
ADDITIVE on the stable tier, with one generated-tier removal and one generated-tier path move:
api.graphs.select_graphis removed. The API deprecated the call in favour ofset_selected_graph(shipped in 2.7.0) and has now removed the endpoint, so the generated function could only meet a 404. No facade wraps it androbosystems-integration-template/src/integration/emit/*.pynever imported it.api.schema.validate_schemais nowapi.graphs.validate_schema; the function and its models are unchanged. Same checks: no facade, not in the template's emit path.Both ride a minor (2.8.0) with the release notes as the record. No model field became required or was dropped: every new request field is optional and defaults server-side to the group parent, so existing calls behave as before.
Testing
just test-all(pytest → format → lint → typecheck): 654 passed, 17 skipped; ruff, format and basedpyright clean.just generate-graphqlrun and clean. The regeneration itself was run against the local backend at the mergedmain.🤖 Generated with Claude Code
https://claude.ai/code/session_01BY3uYE5zMjjFHnjiZfiJu8