Repository navigation
fix(toolchain): print nix attrs before resolving the closed sets (RIG-5489) - #2325
Merged
Merged
Conversation
…-5489) --print-nix-attrs now exits right after the devenv.nix parse and its empty-parse refusal. It no longer evaluates langs, goAnalysis or meissa, which made the pgtest and e2e bootstraps build the Go battery for nothing. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
😎 This pull request was merged. |
|
Compass engineering docs preview: https://ci-rig-5489-parity-print-att.compass-eng-docs.pages.dev Deployed from |
Co-authored-by: Matt Wilkinson <matt@rigel.build>
Contributor
Author
|
Review loop on head
|
Contributor
Author
|
Review loop on head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/toolchain/parity.ts --print-nix-attrsnow exits straight after thedevenv.nixparse and that parse's own empty-result refusal.langs,goAnalysisandmeissabefore printing.Measured
Dispatch run 38841392253 on this head, compared with 38839237527 on main plus T3:
In that run
moon (go)failed. The nilaway Go-modules fetch got a transient download error from the Go module proxy storage, outside this diff, so I re-ran the failed jobs.Tests
tools/toolchain/parity.test.ts:--print-nix-attrswith every closed-set JSON missing from the stubnixprints["buf"]and exits 0. Before the fix it failed (red run: 11 pass, 1 fail).devenv.nixparse still exits 1.langsset fails the verdict path. It fails when that guard is removed (12 pass, 1 fail).bun test tools/toolchain/: 117 pass, 0 fail.biome ci tools/toolchain: clean apart from 2 warnings that already exist on main.Design:
docs/designs/compass/ci-pr-speed.md§ T2 in RigelBuild/docs. Issue: RIG-5489.