Repository navigation
fix(connector-hermes): no unanchored channel sends in a shared session - #95
Merged
Merged
Conversation
With single_session and channel_replies=false, a send naming no message (progress, a turn-error notice) fell back to the running turn's origin and posted to the channel. Drop it when that origin is a channel. Co-authored-by: Matt Wilkinson <matt@rigel.build>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #94 now that Nemo runs
single_session(orion#4826). In the shared session, a send that names no message (progress, a turn-error notice) falls back to the running turn's origin. Withchannel_replies: falseand a channel turn running, that still posted to the channel.Change
send(): in the shared chat, an unanchored send whose fallback origin is a channel is dropped whenchannel_repliesis false.Tests
pnpm smoke:hermes-channel-replies:COTAL_SMOKE_SENTINEL cells=20 passed=20 failed=0; the new shared-mode cell failed before the fix (the send reached#ops).pnpm smoke:hermes-single-session: 25/25.