Print Mayer bond orders in Gaussian jobs - #952
Open
kfir4444 wants to merge 1 commit into
Open
Conversation
This was referenced Aug 10, 2026
kfir4444
force-pushed
the
mayer_bond_orders_g16_route
branch
from
August 10, 2026 09:09
38df498 to
6146de7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mayer_bond_orders_parser #952 +/- ##
===========================================================
Coverage ? 63.62%
===========================================================
Files ? 114
Lines ? 38443
Branches ? 10052
===========================================================
Hits ? 24461
Misses ? 11061
Partials ? 2921
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 2/5 — based on #951, review that one first.
What
IOp(2/9=2000)→IOp(2/9=2000,6/80=1)in the Gaussian route section.Why
6/80=1makes Gaussian print the Mayer atomic bond orders that #951 parses. It is a post-SCF population analysis and its cost is negligible. Orca prints the same analysis by default, so there is no equivalent change on that side.Making it unconditional rather than opt-in means every Gaussian log ARC produces from here on can be used for connectivity perception, including the IRC endpoint optimizations in the later PRs of this stack.
Note for reviewers
This changes every Gaussian input ARC writes, which is why 25 expected route strings in
gaussian_test.pychange with it. The expected values changed because the generator deliberately changed — no assertion was relaxed to accommodate new behaviour, and the change is a single token in one template line.arc/job/adapters/psi_4.pycarries a copied Gaussian-style route line containing the sameIOp(2/9=2000). It was deliberately left alone as out of scope.Testing
pytest arc/job/— 985 passed, 3 failed. All three failures (test_which, two xTB tests) are environment-dependent and reproduce onmain.🤖 Generated with Claude Code