Add Apache-2.0 license - #29
Open
RayZhao1998 wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为什么补
仓库没有
LICENSE文件。README 第一句写着 "open source"(TreeKit is a model-first file tree rendering component),但没有授权文件时法律默认是 保留所有权利 —— 别人 clone、依赖、二次分发在授权层面都是空白。对一个希望被采用的开源组件来说,这比任何功能缺口都靠前。为什么是 Apache-2.0
DiffKit用的就是 Apache-2.0,两个组件经常被同一批用户看到,许可不一致只会增加采用成本。THIRD_PARTY_NOTICES.md里只有一项 ——pierrecomputer/vscode-iconsv0.0.9(rev04a9028),MIT。MIT 许可的材料可以和 Apache-2.0 组合作品一起分发,条件是保留其声明;这一条你已经做到了(Sources/TreeKit/Resources/ThirdParty/pierre-vscode-icons-LICENSE.md+ notices 文件),正好满足 Apache-2.0 §4(b)「给收到作品的每个接收者附带许可证副本」的意图。所以加这个文件不需要改动任何现有资源。版权行怎么填的
Copyright 2026 Ziyuan ZhaoZiyuan Zhao <ninjiacoder@gmail.com>(另 13 个是Ray Zhao,同一邮箱)。如果你想统一成Ray Zhao,改一行就行。2026-08-09 Add cross-platform TreeKit an…,所以是 2026。DiffKit/LICENSE的原文,两份的唯一差异就是这一行 Copyright。验证(数字都是实跑出来的)
swift build/swift test行为不受影响顺带发现(不在这个 PR 里改)
DiffKit/LICENSE末尾的版权行还是 Apache 模板的占位符原样:Apache-2.0 正文不要求填它(那是 Appendix 的示例 header),但一份主张版权的 LICENSE 通常要填真实权利人 —— 否则将来维权时"谁在主张权利"这一环是空的。建议 DiffKit 也补一行。