Skip to content

Add disable_feature and enable_feature to TestUtilitiesController - #963

Merged
PetarSimonovic merged 2 commits into
mainfrom
test_utilities_feature_toggles
Aug 13, 2026
Merged

Add disable_feature and enable_feature to TestUtilitiesController#963
PetarSimonovic merged 2 commits into
mainfrom
test_utilities_feature_toggles

Conversation

@PetarSimonovic

@PetarSimonovic PetarSimonovic commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Add endpoints to allow tests to universally enable or disable features

What's changed?

  • add enable_feature action
  • add disable_feature action
  • remove hard-coded feature seeds
  • update controller specs

@cla-bot cla-bot Bot added the cla-signed label Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Test coverage

92.26% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/31694350112

@PetarSimonovic
PetarSimonovic force-pushed the test_utilities_feature_toggles branch 2 times, most recently from 823b3bc to e2b0e67 Compare August 12, 2026 17:39
@PetarSimonovic
PetarSimonovic requested a lite review from Copilot August 12, 2026 17:42
@PetarSimonovic
PetarSimonovic force-pushed the test_utilities_feature_toggles branch 3 times, most recently from 5d2bce9 to 3aa2ed1 Compare August 12, 2026 18:02
@raspberrypiherokubot
raspberrypiherokubot temporarily deployed to editor-api-p-test-utili-zoqwtc August 12, 2026 18:09 Inactive
@PetarSimonovic
PetarSimonovic temporarily deployed to editor-api-p-test-utili-zoqwtc August 13, 2026 09:08 Inactive
Comment thread lib/tasks/test_seeds.rake
Comment on lines -55 to -56
Flipper.enable_actor :cat_mode, school
Flipper.enable_actor :student_sso, school

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully these changes mean that we no longer need to hard-code features.

And I think cat_mode is no longer in use.

@PetarSimonovic
PetarSimonovic force-pushed the test_utilities_feature_toggles branch from f9a495e to 1ce85cf Compare August 13, 2026 10:58
@PetarSimonovic
PetarSimonovic temporarily deployed to editor-api-p-test-utili-zoqwtc August 13, 2026 10:58 Inactive
Comment thread app/controllers/test_utilities_controller.rb Fixed
@PetarSimonovic
PetarSimonovic force-pushed the test_utilities_feature_toggles branch from 1ce85cf to dd2263b Compare August 13, 2026 11:10
@PetarSimonovic
PetarSimonovic temporarily deployed to editor-api-p-test-utili-zoqwtc August 13, 2026 11:11 Inactive
@PetarSimonovic
PetarSimonovic marked this pull request as ready for review August 13, 2026 11:35
@PetarSimonovic
PetarSimonovic merged commit f4edc96 into main Aug 13, 2026
8 checks passed
@PetarSimonovic
PetarSimonovic deleted the test_utilities_feature_toggles branch August 13, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants