align skill helper script paths with scripts/ convention (#143) - #144
Merged
Conversation
Collaborator
|
@r2dedios pls take a look, thank you! |
r2dedios
requested changes
Jul 24, 2026
operetz-rh
force-pushed
the
fix/issue-143-skill-script-paths
branch
from
July 27, 2026 10:28
27bf5a4 to
9db39cc
Compare
r2dedios
requested changes
Jul 27, 2026
r2dedios
left a comment
r2dedios
left a comment
Contributor
There was a problem hiding this comment.
Looks much better! Just a suggestion about re-using the $SCRIPTS_DIR like in other SKILLS
operetz-rh
force-pushed
the
fix/issue-143-skill-script-paths
branch
from
August 5, 2026 10:46
9db39cc to
f3a5275
Compare
4 tasks
Contributor
|
LGTM! nice work @operetz-rh |
r2dedios
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pack(s) affected
ocp-adminrh-ai-engineerrh-automationrh-basicrh-developerrh-srerh-virtChange type
mcps.json)Contribution method
/agentic-contribution-skillmake validate+make validate-skill-design-changed)Pack-persona alignment (new skills only)
AGENTS.md compliance
${VAR}referencesValidation
make validatepasses locallyname,description)name,description)