fix: read the source system through QuestBase.source - #513
Merged
Merged
Conversation
QuestBase 0.5 replaced `HarmonicEquation`'s `natural_equation` field with `source_equations` on a type parameter, so that harmonic equations are no longer assumed to come from a second order `DifferentialEquation`. `fourier_transform!` was the one place reaching for the old field. Bumps the QuestBase and HarmonicSteadyState bounds to the releases carrying the source accessors. Breaking, since anything reading `natural_equation` off an equation built here has to move to `QuestBase.source` as well.
The benchmark environment pins its own copies of the QuestBase and HarmonicSteadyState bounds, and they still named the pre-source releases. That conflicted with the package's own bounds, so the benchmark job failed to resolve HarmonicSteadyState with "restricted to versions 0.5 by project" while HarmonicBalance asked for 0.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QuestBase 0.5 replaced
HarmonicEquation'snatural_equation::DifferentialEquationfield withsource_equations::Ton a new type parameter, so that harmonic equations are no longer assumed to come from a second orderDifferentialEquationin the lab frame.fourier_transform!was the one place in this package reaching for the old field:Everything else here already goes through the constructors rather than the fields, so no other change was needed.
Compat bounds move to the releases that carry the source accessors:
QuestBase = "0.5"andHarmonicSteadyState = "0.6".Related issues or PRs
Part of a coordinated change across three packages:
source/source_typeand reparametrisesHarmonicEquation(merged, releasing as 0.5.0).HomotopyContinuationProblemandResult.This one is not optional. HarmonicBalance is in HarmonicSteadyState's test target, so its test suite cannot load until this lands.
Additional context
Breaking, so this releases as 0.18.0. Anything reading
natural_equationoff an equation built here has to move toQuestBase.sourcetoo, and a patch release would have been auto-resolved by already-released versions pinned toQuestBase = "0.4.1".Tested locally against the two branches above with
[sources]overrides: full suite green.