fix: stop Schwab submissions after an unknown broker outcome - #394
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Audit F1: one cycle-wide halt after uncertain submit, malformed/unknown response, ambiguous HTTP failure, or failed post-ACK processing. Preserve original intent, known order ID and ACK without claiming a fill. Skip sell-refresh/resume after halt. Append submitted/unknown orders to the existing outcome store without replacing its claim. Notification failures are sanitized and cannot discard pending outcomes.
Verification
Boundaries
No deployment, config sync, provider/broker/account or order operation. Deploy workflow is dispatch-only; this main push runs CI only. A code/test fix does not establish production adoption or completed reconciliation.