Repository navigation
Keep Secure and HttpOnly when overwriting cookies. - #501
Open
Cherith1222 wants to merge 1 commit into
Open
Cherith1222 wants to merge 1 commit into
Cherith1222 wants to merge 1 commit into
Conversation
Reloading Set-Cookie dropped valueless flags, so SameSite=None raised ValueError and other cookies lost Secure or HttpOnly. AI-assisted (Cursor). Not yet reviewed by a human.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #417.
Response.set_cookie(..., overwrite=True)reloaded existingSet-Cookieheaders and dropped the valuelessSecureandHttpOnlyflags. Overwriting a cookie besideSameSite=Nonethen raisedValueError, and other cookies lost those flags.Tests, on Windows with Python 3.13 and
legacy-cgi,PYTHONPATH=src, via Resource Sentinel (1 CPU, 1.5 GiB, 1 I/O):With
src/webob/cookies.pychecked out atmain,test_set_cookie_overwrite_keeps_secure_and_httponlyfailed withValueError: Incompatible cookie attributes: when the samesite equals 'none', then the secure must be True.On this commit the same test passed (1 passed, 178 deselected).
black --checkandisort --check-onlypassed onsrc/webob/cookies.pyandtests/test_response.py.Not run: the tox matrix, other Python versions, and anything other than Windows.
CHANGES.txthas a Bugfix note for this. There is no pull request template.Drafted with Cursor. Cherith reviewed this diff and confirmed it with the person who helped draft it. There is no Co-authored-by or Signed-off-by trailer.