[Bug]: partial_match suffix check uses virtual_suggestion (prefix only) instead of full suggestion #62

Activity

1. github-actions

   added

   bugSomething isn't workingSomething isn't working

   on May 24, 2026
2. PyDevC

   added

   AI genIssue was generated by AIIssue was generated by AI

   on May 24, 2026
3. PyDevC commented on May 24, 2026

   

   PyDevC

   on May 24, 2026

   Owner

   More actions

   /oc can you describe this issue?
4. opencode-agent commented on May 24, 2026

   

   opencode-agentBot

   on May 24, 2026 – with OpenCode Agent

   More actions

   Here's the bug analysis:

   The Bug

   In lua/model_cmp/utils.lua:82, the partial_match function checks if the suffix (text after cursor) exists in the suggestion, but it searches inside virtual_suggestion instead of the full suggestion.

   The problem

   virtual_suggestion is only the prefix portion of the suggestion (first #prefix characters), so when there's any text after the cursor, the suffix can never be found there, and the function always returns nil — rejecting even perfectly compatible suggestions.

   Example

   Buffer line: return 1;, cursor after return , model suggests return 1;:

   • prefix = "return ", suffix = "1;", suggestion = "return 1;"
   • virtual_suggestion = "return " (only first 7 chars)
   • string.find("return ", "1;") → nil → incorrectly rejected

   The fix on line 82 is to change virtual_suggestion → suggestion:

   - local s, _ = string.find(virtual_suggestion, suffix)
   + local s, _ = string.find(suggestion, suffix)

   Existing tests never hit this path because none of them have text after the cursor (curr == prefix in all cases, so suffix is always nil).

   
   opencode session  |  github run
5. PyDevC

   added

   maintainer triagedmaintainer has triaged the issuemaintainer has triaged the issue

   on May 26, 2026
6. PyDevC

   changed the title [-]bug: `partial_match` suffix check uses `virtual_suggestion` (prefix only) instead of full `suggestion`[/-] [+][Bug]: `partial_match` suffix check uses `virtual_suggestion` (prefix only) instead of full `suggestion`[/+] on May 26, 2026
7. PyDevC commented on May 26, 2026

   

   PyDevC

   on May 26, 2026

   Owner

   More actions

   This doesn't seems right...

   The reason why I am doing virtual_suggestion instead of full suggestion is because I want it to just search for the prefix instead of full suggestions otherwise it will show suggestions even for words like is or and in between the sentences.
8. PyDevC

   closed this as completedon May 26, 2026