Repository navigation
fix: five failing scripts + promote to smoke (cti-upkeep 3) - #46
Merged
Merged
Conversation
…ling scalar, noise_scaling path + dataset_full; promote to smoke
- dataset_1d/advanced/temporal/{database,plot}.py: take the per-dataset entry [0] of each
FactorGraphModel instance (carries time + cti), as fit.py does
- plot/diagnostics/imaging_ci/well_filling.py: take [0] of the 1-element binned EPER
array (NumPy 2 refuses float() on it)
- imaging_ci/advanced/chaining/noise_scaling.py: read the poisson_traps.py output path,
set dataset.noise_scaling_map_dict directly (set_noise_scaling_map_dict was removed),
pass the already-built imaging_ci_full_list as dataset_full (Result.noise_scaling_map_dict
fits the full dataset)
- smoke_tests.txt: +8 entries (36 -> 44), each after its producers
Closes #45
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under profile_release, visualization fits each dataset_full; search 2's hyper noise scaling then needs noise_scaling_map_dict there as well, or hyper_noise_map_from indexes None. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the five autocti_workspace scripts that the cti-upkeep 3a smoke triage found failing, and adds them to
smoke_tests.txt(36 → 44 entries) so CI covers them. Workspace only: none of the failures needed a library change. Closes #45.Re-run from a fresh clone in dependency order, the five failures turned out to be:
dataset_1d/advanced/temporal/database.pyFactorGraphModel, somax_log_likelihood()returns one entry per dataset plusfactor, with no.time[0], asfit.pydoes withresult_list[0].instancedataset_1d/advanced/temporal/plot.pymedian_pdf/errors_at_*_sigma[0]plot/diagnostics/imaging_ci/well_filling.pyfloat()on the 1-element binned EPER array (NumPy 2 refuses it)[0]imaging_ci/advanced/chaining/noise_scaling.pypoisson/simple/norm_*, butpoisson_traps.pywritespoisson/norm_*; (2) calledset_noise_scaling_map_dict(), which PyAutoCTI removed when the maps became a dict; (3) never passed theimaging_ci_full_listit builds, soResult.noise_scaling_map_dicthitdataset_full=None; (4) underprofile_releasethe visualization of the full dataset needs the maps toonoise_scaling_map_dictdirectly on both the masked and full datasets; passdataset_fullto all three searches' analysesplot/fpa/imaging_ci/database.pyPIXSCAYerror was a triage ordering / stale-output artefactThe "SQLAlchemy error" the triage saw on
temporal/plot.pyonly happens on a second local run: under test mode the script deletesoutput/<name>.sqlite, but the database lives inoutput/test_mode/<name>.sqlite. CI always runs fresh, so it's filed separately asPyAutoMind/draft/bug/autocti_workspace/database_scripts_stale_sqlite_under_test_mode.md(6 scripts share the pattern).Scripts Changed
scripts/dataset_1d/advanced/temporal/database.py: per-dataset instance[0], with an explanation in the prosescripts/dataset_1d/advanced/temporal/plot.py: per-dataset instance[0](median PDF and both error bounds)scripts/plot/diagnostics/imaging_ci/well_filling.py: scalar EPER via[0]scripts/imaging_ci/advanced/chaining/noise_scaling.py: dataset path,dataset_full, noise scaling maps on both datasetssmoke_tests.txt: +8 entries, each after its producers (temporal/database.pyandtemporal/plot.py;poisson_traps.pyandnoise_scaling.py; theplot/fpa/imaging_cisimulator, fit and database;well_filling.py)AGENTS.md: smoke count 36 → 44notebooks/: the four matching notebooks regenerated withgenerate.py autoctiUpstream PR
None (workspace only).
Test Plan
smoke_tests.txtfrom a fresh clone,profile_smoke: 44/44 passed, 573 ssmoke_tests.txtfrom a fresh clone,profile_release: 43/44 on the first run; the failure (noise_scaling.py, full-dataset noise scaling under visualization) was fixed in f00ade8 and re-run green under both profilesTiming note: the
plot/fpa/imaging_cichain is the costliest addition: about 230 s underprofile_smoke(fit 108 s) and about 430 s underprofile_release(fit 296 s). It's kept because the prompt's Witness requires all five scripts in smoke; it's a candidate for/ci_speedupif the release gate's wall time matters.Heart: STALE at ship time, with one reason, acknowledged by the human: "release validation stale: source moved since rehearsal (PyAutoNerves)".
Tier: glance. Merge mode: auto-merge on green if the Witness passes.
🤖 Generated with Claude Code