Repository navigation
feat: campaign collector, digest, propose-only resubmits and retro mode (hpc-campaign p2b) - #1742
Merged
Merged
Conversation
…ective sacct mode (hpc-campaign p2b, #1740) autofit.campaign.collector joins the job ledger's accounting (one sacct call, attempts kept) with the fits' status records (by the job/task ids each fit recorded): the scheduler decides timeout/oom/node_fail/cancelled, the status record the state and failure class otherwise; stage success checks (zip with .completed + members); unsubmitted manifest objects reported. autofit.campaign.digest writes digest.json, a <=2 KB digest.md, tasks.jsonl and failed_<class>.txt: per-stage counts, p50/p95/max wall and RSS vs request, CPU efficiency, CPU-hours split successful vs failed or repeated, disk, ETA, drift flags (timeouts, memory tight/slack, CPU efficiency, CPU-only tasks on a GPU partition, success check). autofit.campaign.proposals sizes resubmits from the failed tasks' own measurements (timeout p95+25 %, OOM peak x1.5, capped by the site, retry max honoured, Python failures never resubmitted) and pending-task scontrol updates; nothing is ever submitted by a proposal. autofit.campaign.retro builds the same digest from a sacct --parsable2 dump alone (WorkDir path-boundary and job-name selection, stage from job name, period, peak concurrency). CLI: status, resubmit, retro, submit --proposal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Full PyAutoFit suite (PyAuto313, local): 2a 4,082 passed / 2b 4,098 passed (2 skipped, 1 xfailed). Smoke |
Base automatically changed from
feature/hpc-campaign-p2-campaign-core
to
main
October 30, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2b of hpc-campaign phase 2 (#1740). Stacked on #1741; merge that first.
collector.py): onesacctcall joined with the fits' status records, matched by the job and task ids each fit recorded. The scheduler decidestimeout/oom/node_fail/cancelled; otherwise the status record gives the state and failure class. It also runs the stage success checks and reports manifest objects that were never submitted.digest.py):digest.jsonholds the full summary;digest.mdis at most 2 KB;tasks.jsonlhas one row per task; failures go infailed_<class>.txt.proposals.py), propose-only per ruling F5:submit --proposal <file>.retro.py): builds the same digest from asacct --parsable2dump alone. Tasks are selected by WorkDir prefix and job-name regex, plus an--other-stagebucket.status,resubmit,retro,submit --proposal.Witness W2 (ruling F4a, read-only, no compute)
retroover the DR1 sacct dump: 67k rows in 13 s → 61,078 Slurm tasks.unrecorded, from before status records existed), 524 cancelled, 12 node_fail, 0 OOM.gpu.Digest and figures are in
Workspace/Science/scratch/hpc_campaign_p2_w2/, which is never committed. Counts are per Slurm task, not per lens.Decisions taken (please check)
cancelled/requeued/preemptedstay campaign-level strings;states.pyis unchanged (results-library owns its edits in this window). A failure with no status record is classedunrecorded. A possible follow-up isRunState.CANCELLED.digest.mdis capped at 2 KB; the JSON carries the full summary.autofit.campaigndoes not re-exportsubmit/retrofunctions (they'd shadow the submodules); import them from the submodules.Test plan
test_autofit/campaign(106): an end-to-endFakeSchedulerrun with injected timeout, OOM, exception and missing-seed tasks giving the right classes, lists and proposals; the digest size cap; a synthetic sacct retro.Refs #1740
🤖 Generated with Claude Code