fix: rectangular-mesh pcolormesh plots misaligned with mapper node convention #372

Activity

1. Jammy2211 commented on Jul 10, 2026

   

   Jammy2211

   on Jul 10, 2026

   CollaboratorAuthor

   More actions

   Ship sign-off question (supervised --auto run parks here per the autonomy contract)

   Implementation complete in the worktree (~/Code/PyAutoLabs-wt/rect-adapt/PyAutoArray, branch feature/rect-adapt, deliberately uncommitted pending this sign-off).

   What was being done: the reported "small offsets" in rectangular-mesh source-reconstruction plots — confirmed real via a delta-function reproduction (dominant flux cell plotted ~1.5 mesh pixels from its true node in y).

   The change (1 file + 1 test):

   • autoarray/inversion/mesh/mesh_geometry/rectangular.py::edges_transformed — replaces the uniform [0,1] unit-space partition with the interpolation mapper's node-midpoint edges (U_x = (c−1.5)/(n−3), U_y = (n−r−0.5)/(n−3), guard-safe denominator for degenerate n≤3 meshes), transformed through the existing CDF machinery unchanged. Corrected the docstring (was a copy-paste about pixel neighbors). Both consumers inherit the fix: the pcolormesh plot path and rectangular_rotated.py's warped-centre reconstruction. Spline and linear CDF variants share the same index convention ((n−3)·U + 1), so both are fixed upstream.
   • New regression test: delta scattered through the mapper → weighted centroid of the plotted cells matches the input point to sub-cell precision (pre-fix uniform edges miss by ~0.4 units ≈ 1.5 cells in y).

   Gate status: full suite 877 passed (incl. the pre-existing test__edges_transformed, whose 3×3 expectation is preserved by CDF clamping, and the rotated-mesh ghost tests). Review-faculty + smoke + Heart legs run at ship, after this sign-off.

   On approval: commit, push, open the PR (with ## API Changes: changed behaviour of edges_transformed — plot geometry only; no inversion/likelihood surface touched — the mapper itself is unchanged, so reconstructions/likelihoods are byte-identical; only where flux is drawn moves). On rejection: the worktree is disposable.

   Recommendation: ship — the fix is small, mapper-consistent by construction, and the misalignment it removes is exactly what the report describes.
2. Jammy2211 commented on Jul 10, 2026

   

   Jammy2211

   on Jul 10, 2026

   CollaboratorAuthor

   More actions

   Sign-off answered in-conversation (go --auto): shipped as PR #375 (suite 877 re-run at ship, review CLEAN, Heart YELLOW within the session ack, MERGEABLE against current main). Merge stays human per the autonomy contract — validation checklist on the PR.
3. Jammy2211 commented on Jul 10, 2026

   

   Jammy2211

   on Jul 10, 2026

   CollaboratorAuthor

   More actions

   Independent verification from the kernel-CDF session (#373/#374): the fix is confirmed, visually and numerically — including on the new kernel meshes.

   Merged feature/rect-adapt (c177391) into feature/rectangular-kernel-cdf-mesh locally (clean merge, distinct hunks as predicted) and built a visual+numeric verification the original fix lacked: autolens_workspace_developer/plotting_alignment/kernel_cdf_alignment.py, on the mass_centre_source_up_more dataset (truth source at (y,x) = (1.0, 0.0), lens fixed at simulator truth, mask r=3.0).

   Renders (real plot_inversion_reconstruction pipeline, full extent): all five meshes place the source at truth — bright centroids/peak cells within ~1 mesh pixel of (1.0, 0.0) and of each other (uniform imshow reference: centroid (0.969, −0.060); adaptive pcolormesh: adapt_image (0.969, −0.031), adapt_density (0.905, −0.014), kernel variants likewise). The reported ~0.5–1.5 px systematic y-shift is gone. PNGs in C:\Users\Jammy\FromWSL\kernel_cdf_alignment\.

   Strict checks (per adaptive mesh — AdaptImage, AdaptDensity, KernelAdaptDensity, KernelAdaptImage):

   • Node containment: every interior node lies inside its drawn pcolormesh cell (guard-ring clamp ties at the few-ulp level only) — holds for all three CDF flavours, as the node-midpoint construction guarantees under any monotone CDF.
   • Mapper-faithfulness: a delta scattered through the mapper draws at the mapper-encoded centroid Σw·node to 0.01–0.07 local cells. The residual |Σw·node − query| = 0.09–0.24 cells is the mapper's own bilinear-in-U interpolation on non-uniform cells — physics, identical pre/post fix, not a plotting error.

   Notes: the kernel meshes inherit the fix automatically through the shared edges_transformed dispatch (verified in the merged code); the Delaunay tripcolor cross-reference is blocked by the pre-existing Delaunay-in-FitImaging crash (#332), so RectangularUniform imshow served as the trusted reference. Post-merge, the full PyAutoArray suite passes on the combined tree (893, including the new regression test), and the #373 jax_grad certification was re-run against the merged library and passes in full.

   Merge order: #375 first is cleanest (my #374 branch already contains c177391 and has re-run its suite + certification on the combined tree, so nothing further is needed on my side whichever lands first).
4. Jammy2211

   closed this as completedin #375on Jul 10, 2026
5. Jammy2211 commented on Jul 10, 2026

   

   Jammy2211

   on Jul 10, 2026

   CollaboratorAuthor

   More actions

   PR #375 merged 2026-07-10 (human-directed, from the kernel-CDF session per the coordinated order #375→#374). Fix verified visually + numerically upthread across linear and kernel adaptive meshes. Closing; the rect-adapt session's registry entry can retire.