Repository navigation
refactor: consolidate oversampled-PSF helpers (convolver + operate/image) #360
Description
Overview
The oversampled-PSF series refactor (PyAutoMind/issued/oversampling_refactor_followup.md, Refactor Agent verdict: too-large score 11 → conservative cut). Behaviour-preserving: the invariant is that both test suites (PyAutoArray, PyAutoGalaxy) and the ground-truth-pinned tests pass unchanged; API guard: none-expected. Effective autonomy: safe (refactor cap).
Scope (this PR)
convolver.py: consolidate the four_convolved_*_over_sampled_{np,jax}_frombodies into shared scatter/convolve/bin helpers (np pair + jax pair each share ~80% of their logic, differing only in trailing dims and kernel choice).operate/image.py(PyAutoGalaxy): extract the thrice-duplicated s>1 evaluation-grid switch into one helper..gitignore: addtest_autoarray/output/(test-run artifacts leaked into a commit once today).
Deferred (recorded, not done)
- The
convolver/package split (state / real-space / FFT / over-sample modules): high churn for zero behaviour value right now; revisit if the file keeps growing. The np/jax/FFT method-variant duplication that predates the series is likewise left for that split. - Dataset validation-helper placement and mapper matrix parameterization: already minimal after review.
🤖 Generated with Claude Code
Activity
Jammy2211 commentedon Jul 8, 2026
Refactor implemented — at the ship checkpoint (Heart YELLOW gates the autonomous ship)
Two local commits, not pushed: PyAutoArray
+124/−155(net −31: the four oversampled helper bodies → two shared engines + thin wrappers; gitignore fix), PyAutoGalaxy+45/−35(the thrice-duplicated s>1 switch → one_psf_evaluation_grids_fromhelper).Invariant verification (behaviour-preserving)
Deferred (recorded per the Refactor Agent's too-large verdict)
convolver/package split and the pre-series np/jax/FFT method-variant duplication — high churn, zero behaviour value today; revisit if the file keeps growing.Effective level is
safe(refactor cap), but the autonomous-ship gate's Heart leg is YELLOW with no launch acknowledgement — parking for the human ship word alongside the docs PR (#235).🤖 Generated with Claude Code
Jammy2211 commentedon Jul 8, 2026
🚢 Shipped (human-approved): PyAutoArray#361 + PyAutoGalaxy#484, both
pending-release, independent (mergeable in either order). Merge on your word.🤖 Generated with Claude Code
refactor: consolidate oversampled-PSF convolution helpers (#360) (#361)
Jammy2211 commentedon Jul 8, 2026
✅ Both merged (mains green): PyAutoArray#361, PyAutoGalaxy#484. Refactor complete; the deferred package split stays recorded above for a future pass.
🤖 Generated with Claude Code