Repository navigation
Restore Chapter 3 fit-problem narrative and consolidate adaptive reconstruction - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chapter 3 had lost the Fit Problems motivation and parts of its introductory teaching content during consolidation. This restores that narrative and presents six consecutive tutorials, ending with one adaptive reconstruction tutorial combining the former tutorials 8, 11 and 12.
The Bayesian evidence explanation now uses the approved Goldilocks analogy and explicitly selects the highest sampled log evidence. Lens modelling explains the large parameter-space volume of incorrect solutions, refers back to Chapter 2 Tutorial 5's positions likelihood penalty, and displays Maresca Figure 1. The preservation audit restores positivity and mapping-support diagnostics in Tutorial 1.
Scripts Changed
scripts/chapter_3_pixelizations/tutorial_1_pixelizations.py— restore missing explanations and diagnostics, with pointers to later mask and mass experiments.scripts/chapter_3_pixelizations/tutorial_2_bayesian_regularization.py— evidence-based coefficient selection and mesh-resolution comparison.scripts/chapter_3_pixelizations/tutorial_3_borders.py— approved border and mask narrative and experiments.scripts/chapter_3_pixelizations/tutorial_4_lens_modeling.py— approved modelling narrative, embedded Maresca figure and likelihood-penalty references.scripts/chapter_3_pixelizations/tutorial_5_fit_problems.py— restore compact-source fit failures motivating adaptation.scripts/chapter_3_pixelizations/tutorial_6_adaptive_reconstruction.py— consolidate overlay/Hilbert meshes, split/adaptive regularization and an MGE-to-pixelization modelling chain; retire tutorials 8, 11 and 12.Regenerated notebooks, contents, navigation and catalogues accompany the scripts. Scans retain scalar evidence and preferred fits to bound memory. The two new morphology experiments declare
ENV: full_datasetsin their developer-only__Env__sections because the small-data cap distorts their evidence curves. The notebooks omit these declarations.Validation
Closes #125.
Readiness
Heart YELLOW acknowledged by the human on 2026-11-04:
workspace validation not passing (0 failed, 1 timeout, cloud#41432188469: autofit_test scripts/searches/MultiStartResumeNaNCounters.py). Development shipping only; GitHub CI remains required for merge.