Conversation
Add TemplatePath and parse-set helpers (shell layout, shell inner pages, auth pages) so handlers stop hardcoding filenames under templates/.
…ortal, partials Move base.html to shell/, auth pages to auth/, portal pages to portal/, and shell inner bodies to pages/ (drop *_inner suffix). Split shared defines into partials (menu icons, home hub, apps module forms, auth assets, login brand aside). Wire RenderPage, shell inner render, auth template cache, setup, and portal handlers via render/templates_paths.go.
… mark Add core.company login_logo and login_tagline with form fields. Resolve sign-in panel branding: company upload via public GET /web/login/logo, then logo_path in config, then bundled sumeru-logo.svg. Modern left-panel CSS with accent classes from company color index. Document host-level logo_path and company_display_name in sumeru.conf.example.
Export build-brand and logo-route helpers for tests. Add logo priority and data-URL parsing tests. Extend login GET test for brand lockup and default SVG. Reset auth template cache when TemplatesPath changes in tests.
CHINMAYVIVEK
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Login tenant branding
core.companyfields:login_logo(image),login_tagline; Login branding group on the company formGET /web/login/logo→ configlogo_path→ default/static/img/sumeru-logo.svgsumeru-login.css, bundledsumeru-logo.svg,sumeru.conf.examplenotes for host-level logo/nameTemplate reorganization
core/engine/templates/:shell/,auth/,pages/,portal/,partials/(+README.md)*_inner.htmltopages/*.htmlrender/templates_paths.goand wired paths inpage.go,shell_render.go,login.go,setup_handlers.go,portal_handlers.go,web_constants.goTests
login_branding_test.go: logo priority, data-URL parsing, logo route 404, brand lockup in login HTMLlogin_csrf_test.go: default SVG / lockup assertions; auth template cache reset in teststestexports.go: branding and cache helpers for external testsCommits included
0e0c9d8— template path helpers26dab0d— template tree move and partials27fea0e— login branding feature4facf87— login branding testsTest plan
/web/login: default Sumeru logo and left panel; sign-in still works (local + SSO if configured)/web/login/logologo_pathin config when company logo empty/web/home,/web/apps,/web/settings,/setup, TOTP login: pages render (no template parse errors)cd sumeru && make