test(planner): cover exact composition end to end - #315
Open
zzylol wants to merge 3 commits into
Open
Conversation
zzylol
force-pushed
the
feat/exact-composition-planner
branch
from
August 30, 2026 18:21
8d33043 to
5859f35
Compare
zzylol
force-pushed
the
test/exact-composition-e2e
branch
from
August 30, 2026 18:21
12b30fc to
4831b43
Compare
zzylol
force-pushed
the
feat/exact-composition-planner
branch
from
August 30, 2026 18:30
5859f35 to
c4135df
Compare
zzylol
force-pushed
the
test/exact-composition-e2e
branch
from
August 30, 2026 18:30
4831b43 to
bd898fd
Compare
zzylol
force-pushed
the
feat/exact-composition-planner
branch
from
August 30, 2026 18:35
c4135df to
be9b131
Compare
zzylol
force-pushed
the
test/exact-composition-e2e
branch
from
August 30, 2026 18:35
bd898fd to
ec95e46
Compare
zzylol
force-pushed
the
feat/exact-composition-planner
branch
from
August 30, 2026 18:46
be9b131 to
88bced3
Compare
zzylol
force-pushed
the
test/exact-composition-e2e
branch
from
August 30, 2026 18:46
ec95e46 to
91fc851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #314.
Why
Composition crosses frontend lowering, search, costing, materialization, state validation, and export.
Before this PR
No integration suite proved that complete externally visible path.
After this PR
Eleven cases cover both placements. For example, PromQL
max by (zone)overquantile_over_timecomposes and exports read-time rows; an estimate beneath maintenance is rejected.What and how
Covers accuracy, fallback behavior, shared materialization, multi-row folds, PromQL lowering, invalid transitions, and structured DAG details.
Verification
cargo test -p asap-integration-tests --test exact_composition(11 tests)Stack
Base: #314. Next: #312.