Release ThreadPilot 1.6.0 CPU assignment modes - #50
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7381a68dbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (selection.LogicalProcessors.Any(processor => processor.Group != 0)) | ||
| { | ||
| return true; |
There was a problem hiding this comment.
Don’t reject every group-aware soft assignment
When the selected CPUs include any processor group other than 0, this returns true solely because ProcessModel.ProcessorAffinity is positive, so explicit CPU Sets and Ideal Processor modes stop with ProcessRestartRequired before reaching their group-aware APIs. On >64-CPU systems a normal live process still has a positive legacy affinity mask, so restarting will not change this condition and any selection containing CPU 64+ is permanently blocked in those explicit modes.
Useful? React with 👍 / 👎.
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Sintesi
Validazione
Nota
Gli artefatti non sono firmati Authenticode se i secret di firma opzionali non sono configurati nella pipeline.