Repository navigation
lowerSpreadProb and maxFireSpread default to the fireSenseUtils constants - #26
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
eliotmcintire
force-pushed
the
fix/covariate-consistency
branch
from
October 5, 2026 18:23
7647c34 to
1127747
Compare
eliotmcintire
added a commit
that referenced
this pull request
Oct 5, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends-on: PredictiveEcology/fireSenseUtils#132
Item 6.
lowerSpreadProb(0.13) andmaxFireSpread(0.28) were separate literals here and in the fit; they now default tofireSenseUtils::spreadProbFloorandfireSenseUtils::spreadProbCeiling(0.276, the same ceiling the fit boundsmaxAsymptotewith).maxFireSpreadis only checked for agreement across modules and does not change a prediction. ThereqdPkgsfloor stays at fireSenseUtils >= 0.2.3.9083 (current development); it gets raised after PredictiveEcology/fireSenseUtils#132 merges.Tests: the new default test and the updated metadata test fail on base code and pass here. Full suite via convertToPackage + test_local: this branch 145 pass, 0 fail; base 143 pass, 0 fail.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv