Skip to content

fix: notify Slack when a release is rejected at the approval gate #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ioannisj merged 2 commits into from
Sep 1, 2026
Merged

fix: notify Slack when a release is rejected at the approval gate #908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83cb7cb
fix: notify Slack when a release is rejected at the approval gate
ioannisj Sep 1, 2026
d6087af
fix: keep multiline rejection comments intact in the Slack notification
ioannisj Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,3 +527,48 @@ jobs:
thread_ts: ${{ needs.notify-approval-needed.outputs.slack_ts }}
message: "馃殌 posthog-python released successfully!"
emoji_reaction: "rocket"

notify-rejected:
name: Notify Slack - Rejected
needs: [version-bump, notify-approval-needed]
runs-on: ubuntu-latest
if: always() && needs.version-bump.result == 'failure' && needs.notify-approval-needed.outputs.slack_ts != ''
permissions:
actions: read
steps:
- name: Check for rejection
id: check-rejection
env:
GH_TOKEN: ${{ github.token }}
run: |
RESPONSE=$(gh api /repos/${{ github.repository }}/actions/runs/${{ github.run_id }}/approvals)
REJECTED=$(echo "$RESPONSE" | jq '[.[] | select(.state == "rejected")] | length')
if [ "$REJECTED" -gt 0 ]; then
echo "was_rejected=true" >> "$GITHUB_OUTPUT"
COMMENT=$(echo "$RESPONSE" | jq -r 'first(.[] | select(.state == "rejected") | .comment // empty)')
if [ -n "$COMMENT" ]; then
# Random delimiter: a rejection comment is reviewer-controlled text, and a
# literal delimiter line inside it would close the block early and let the
# rest be parsed as step outputs.
DELIMITER="EOF_$(openssl rand -hex 16)"
{
echo "message<<$DELIMITER"
echo "馃毇 Release was rejected: $COMMENT"
echo "$DELIMITER"
} >> "$GITHUB_OUTPUT"
else
echo "message=馃毇 Release was rejected." >> "$GITHUB_OUTPUT"
fi
else
echo "was_rejected=false" >> "$GITHUB_OUTPUT"
fi

- name: Notify Slack - Rejected
if: steps.check-rejection.outputs.was_rejected == 'true'
uses: posthog/.github/.github/actions/slack-thread-reply@cb0979b67dcd585828b61ac45927eef4da8f6287 # main
with:
slack_bot_token: ${{ secrets.SLACK_CLIENT_LIBRARIES_BOT_TOKEN }}
slack_channel_id: ${{ vars.SLACK_APPROVALS_CLIENT_LIBRARIES_CHANNEL_ID }}
thread_ts: ${{ needs.notify-approval-needed.outputs.slack_ts }}
message: "${{ steps.check-rejection.outputs.message }}"
emoji_reaction: "no_entry_sign"