Set the version to 1.2.31 - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.2.30 is live on handsets and it destroys menus. This is the release that fixes it, so it should go out rather than wait.
The one that matters
Saving one dish deleted the entire menu (#134).
saveDataclears the store before writing, and the sold-out long press shipped in v1.2.30 used it to save one dish. So a waiter marking one dish as finished wiped every dish on their handset, mid-service, with no way back but a sync.That was mine. Anyone who updated to v1.2.30 has it.
The same call was behind the other symptom you reported: "i added one item and try to search other items add nothing listed." Adding a one-off item deleted the menu and left the one row behind, and search was honestly reporting there was nothing else to find.
Also in this release
Quick sale has a permanent way in (#133). The offer only appeared when a search matched nothing, which covers "birthday cake" and misses the case a restaurant actually hits: typing "Fish" finds Fish Curry, so the search is not empty and the offer never came. There is now a + beside Clear, always there, which takes whatever is in the box as the name.
The phone says when it is not on a network at all (#135). Wi-Fi and mobile data both off is the one cause a phone can be certain of and a waiter can fix in five seconds, and it was the one case the outage screen never mentioned. Told the till is not responding while their Wi-Fi is simply off, somebody goes and restarts a working computer.
And a test that Try now retries the server it is on. It always did, and nothing proved it, so a change to the candidate order could have quietly turned it into "go and find a different till".
Verification
477 unit tests and 328 browser tests through the pre-commit hook. Tamil added for every new string.
After merging, tag
v1.2.31to build and publish the APK and IPA. Given what v1.2.30 does to a menu, the handsets should be updated the same day.