Skip to content

Fix HashableProp tests - #2801

Open
ljeub-pometry wants to merge 1 commit into
db_v4from
fix_prop_hash_test
Open

ljeub-pometry wants to merge 1 commit into
db_v4from
fix_prop_hash_test

Conversation

@ljeub-pometry

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

  • The proptest for HashableProp was using equality checks on Prop instead of HashableProp
  • Add explicit tests for the floating point edge cases (these were all handled correctly)

Why are the changes needed?

spurious test failure

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Are there any further changes required?

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: ab4072f Previous: 9823ef7 Ratio
lotr_graph/num_edges 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 4 ns/iter (± 0) 1 ns/iter (± 0) 4
lotr_graph/graph_latest 2 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 6378174 ns/iter (± 286615) 1564816 ns/iter (± 35303) 4.08
lotr_graph_window_100_materialise/materialize 5897647 ns/iter (± 410505) 1669150 ns/iter (± 10700) 3.53
lotr_graph_window_10_materialise/materialize 2725822 ns/iter (± 108931) 971980 ns/iter (± 4278) 2.80
lotr_graph_subgraph_10pc/num_nodes 12 ns/iter (± 0) 4 ns/iter (± 0) 3
lotr_graph_subgraph_10pc_materialise/materialize 1878513 ns/iter (± 17713) 334634 ns/iter (± 1287) 5.61
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1176802 ns/iter (± 38889) 230399 ns/iter (± 2617) 5.11
lotr_graph_window_50_layered/has_node_existing 273 ns/iter (± 19) 129 ns/iter (± 12) 2.12
lotr_graph_window_50_layered_materialise/materialize 20332050 ns/iter (± 591666) 3488825 ns/iter (± 24948) 5.83
lotr_graph_persistent_window_50_layered/num_edges_temporal 399580 ns/iter (± 21768) 192686 ns/iter (± 1569) 2.07
lotr_graph_persistent_window_50_layered_materialise/materialize 38059427 ns/iter (± 1304986) 5298035 ns/iter (± 147912) 7.18

This comment was automatically generated by workflow using github-action-benchmark.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants