Fix HashableProp tests - #2801
Open
ljeub-pometry wants to merge 1 commit into
Open
ljeub-pometry wants to merge 1 commit into
ljeub-pometry wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: ab4072f | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/graph_latest |
2 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
6378174 ns/iter (± 286615) |
1564816 ns/iter (± 35303) |
4.08 |
lotr_graph_window_100_materialise/materialize |
5897647 ns/iter (± 410505) |
1669150 ns/iter (± 10700) |
3.53 |
lotr_graph_window_10_materialise/materialize |
2725822 ns/iter (± 108931) |
971980 ns/iter (± 4278) |
2.80 |
lotr_graph_subgraph_10pc/num_nodes |
12 ns/iter (± 0) |
4 ns/iter (± 0) |
3 |
lotr_graph_subgraph_10pc_materialise/materialize |
1878513 ns/iter (± 17713) |
334634 ns/iter (± 1287) |
5.61 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1176802 ns/iter (± 38889) |
230399 ns/iter (± 2617) |
5.11 |
lotr_graph_window_50_layered/has_node_existing |
273 ns/iter (± 19) |
129 ns/iter (± 12) |
2.12 |
lotr_graph_window_50_layered_materialise/materialize |
20332050 ns/iter (± 591666) |
3488825 ns/iter (± 24948) |
5.83 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
399580 ns/iter (± 21768) |
192686 ns/iter (± 1569) |
2.07 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
38059427 ns/iter (± 1304986) |
5298035 ns/iter (± 147912) |
7.18 |
This comment was automatically generated by workflow using github-action-benchmark.
fabubaker
approved these changes
Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HashablePropwas using equality checks onPropinstead ofHashablePropWhy are the changes needed?
spurious test failure
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?