--max-episode-steps did nothing - #3
Merged
Merged
Conversation
make() applied a TimeLimitWrapper using only env_spec.max_episode_steps, the
value fixed at registration. A max_episode_steps passed at make time was
stashed onto the config a few lines below and then never read back, so the
registered default won and the CLI flag silently had no effect.
Measured before the fix, with Dummy-v1 whose registered default is 200000:
gym.make_vec(..., max_episode_steps=3)
step 1..6: truncated=False
and after:
step 3: truncated=True
The fix and its test are nothingbutbut's, from the unmerged
features/robocasa branch. The test runs unchanged on main.
Co-Authored-By: nothingbutbut <2367347983@qq.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make()applied aTimeLimitWrapperusing onlyenv_spec.max_episode_steps- the value fixed at registration. Amax_episode_stepspassed at make time was stashed onto the config a fewlines below and never read back, so the registered default won and the CLI
flag silently had no effect.
Measured before, with
Dummy-v1whose registered default is 200000:after:
The fix and its test are nothingbutbut's, from the unmerged
features/robocasabranch; the test runs unchanged on main.🤖 Generated with Claude Code