Repository navigation
Staging - #84
Merged
Merged
Staging#84
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
data/seed-ci.json is a static snapshot db_fields_check.py validates every db-tagged struct field against, and it isn't updated automatically when an exp/*.sql migration lands. bot_commands, bot_changelogs, reports, and packs.pack_type were all missing, which is what broke the last CI run. Also gives BotPack.Emojis the trailing comment the internal-field check requires, same as its Bots/Servers siblings already have. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Nothing in CI actually ran `go build`/`go vet` against the root popplio module before this: tests.yml only builds cmd/kitehelper (to run its own Go test binary), so a change that broke the main module's compilation had no automated check catching it. Runs both modules as a matrix so a failure names which one broke. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+11
to
+39
| name: ${{ matrix.module.name }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| module: | ||
| - name: popplio | ||
| dir: . | ||
| - name: kitehelper | ||
| dir: cmd/kitehelper | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: 'true' | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: ${{ matrix.module.dir }}/go.mod | ||
| cache-dependency-path: ${{ matrix.module.dir }}/go.sum | ||
|
|
||
| - name: go build | ||
| working-directory: ${{ matrix.module.dir }} | ||
| run: go build -v ./... | ||
|
|
||
| - name: go vet | ||
| working-directory: ${{ matrix.module.dir }} | ||
| run: go vet ./... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.