Skip to content

A draft pull request opened with the description of the state script, and nothing of the session's - #95

Merged
PierreMardon merged 1 commit into
mainfrom
fix/pull-request-description-piped
Oct 5, 2026
Merged

PierreMardon merged 1 commit into
mainfrom
fix/pull-request-description-piped

Conversation

@PierreMardon

@PierreMardon PierreMardon commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

What changes

/surface-plan gives the output of surface-status pr-body to gh on its standard input, as /surface-execute already does at every refresh: gh pr create --draft --body-file - when the branch has no pull request, gh pr edit --body-file - when it has one.

Why

In 3 of the 6 runs of the fourth campaign of the evaluations that had a gh to call, the draft pull request was opened with the text the state script prints followed by a line of attribution, where the prompt says "and nothing else" (#93). The stand-in gh of #91 let it be seen for the first time.

The two commands did not ask for the same thing:

  • /surface-plan named gh pr create --draft "with [...] that description" and gh pr edit --body, and left the session to carry the text. Every session wrote it to a file of its own first, and three added a footer to it.
  • /surface-execute gives the output of the script to gh pr edit --body-file - on its standard input, and no refresh of the three runs played whole carries a footer.

A sentence did not turn that default of the session off every time. A command that leaves it no text to write does.

Files

  • skills/surface-plan/SKILL.md, "Committing, pushing, the pull request": the two calls, and their reason.
  • tests/prompts/test_surface_plan.py: the contract test of the draft holds the two calls, the reason, and that gh pr edit --body is gone.

Measured

On 05-fine-cap, where the footer was written in two runs of two, three runs played to the hand over from this branch (.evals/fix-93/, out of git; 19 sessions, 4.94 USD):

Campaign 4 This branch
Drafts opened with a footer under the description 2 of 2 0 of 3
pr_described at the hand over 0 1
The call gh pr create --draft --title "..." --body-file /tmp/prbody.md gh pr create --draft --title "..." --body-file -

In the run that took a correction, the description of the second revision is set by gh pr edit --body-file -, with no footer either.

Not measured: the other cases, and a real gh, whose --body-file - the stand-in imitates.

Refs #93

… and nothing of the session's

In 3 of the 6 runs of the fourth campaign of the evaluations that had a `gh` to call, the
draft pull request was opened with the text `surface-status pr-body` prints followed by a
line of attribution, where the prompt says "and nothing else" (#93). The stand-in `gh` of
#91 let it be seen for the first time.

The two commands did not ask for the same thing. `/surface-plan` named `gh pr create --draft`
"with [...] that description" and `gh pr edit --body`, and left the session to carry the
text: every session wrote it to a file of its own first, and three added a footer to it.
`/surface-execute` gives the output of the script to `gh pr edit --body-file -` on its
standard input, and no refresh of the three runs played whole carries one.

`/surface-plan` now does the same: the output of the script is given to `gh` on its standard
input, with `gh pr create --draft --body-file -` when the branch has no pull request and
`gh pr edit --body-file -` when it has one.

Measured on `05-fine-cap`, where the footer was written in two runs of two: three runs
played to the hand over, three drafts opened from the standard input with the description
alone, and at every hand over the description is the one the script prints. 19 sessions,
4.94 USD.
@PierreMardon
PierreMardon force-pushed the fix/pull-request-description-piped branch from 57b4e3a to 35d9d1e Compare October 5, 2026 11:17
@PierreMardon
PierreMardon merged commit 1cc1238 into main Oct 5, 2026
3 checks passed
@PierreMardon
PierreMardon deleted the fix/pull-request-description-piped branch October 5, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant