Repository navigation
Added ConfigurableEffect base class for configurable effects - #2371
Merged
cameronwhite merged 3 commits intoNov 7, 2026
Merged
Conversation
Member
|
Looks good to me 👍 My only suggestion would be adding some brief doc comments to the class since this will be used for add-ins |
Contributor
Author
|
@cameronwhite I added a short description explaining the default mechanism |
Added XML documentation for the ConfigurableEffect class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #2327.
Almost all configurable effects in Pinta override
IsConfigurable => trueand launchSimpleEffectDialogas their configuration UI.This change adds a
ConfigurableEffectbase class that setsIsConfigurable => trueand launches the simple effect dialog by default inLaunchConfiguration (ILivePreviewSession).Also,
BrightnessContrastEffectis updated to inherit from it and serve as a sample of how it would work. Once the remaining configurable effects are migrated, the parameterlessLaunchConfigurationoverload onBaseEffectcan be removed.And I am considering that later we could pattern-match instead of checking the
IsConfigurableproperty, for better type safety.