Repository navigation
fix: detect escaped source references in consumer impact - #51
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When source exports or imports a development path through JavaScript escape spelling, the consumer-impact classifier previously missed a later target-only edit. Decode committed source escapes before testing for parent references, including arbitrary leading-zero braced Unicode and line continuations; uncertain source blobs remain possible consumer impact.
Regression fixtures cover static exports and dynamic imports followed by target-only changes, ordinary development-only edits, invalid source encodings, NUL and out-of-range escapes. Base/head ancestry and missing-base behavior stay conservative. No runtime utilities, package exports or runtime gitlinks change.
Validation: focused classifier suite 40/40;
pnpm verify832/832. Independent review reproduced and corrected the leading-zero Unicode case. The Semgrep registry-trust assessment and genuinely affected consumer helper pins are tracked separately under #50, so this PR does not auto-close the full assessment issue.Refs #50.