Skip to content

Include DLL names in instruction rebuild warnings - #27

Merged
Metadorius merged 1 commit into
masterfrom
diagnostics/report-hook-dll
Oct 20, 2026
Merged

Metadorius merged 1 commit into
masterfrom
diagnostics/report-hook-dll

Conversation

@Belonit

@Belonit Belonit commented Aug 23, 2026

Copy link
Copy Markdown
Member

Summary

  • Include the names of hook DLLs in RebuildInstructions warnings.
  • Collect and deduplicate DLL names for hooks that override the same target address.
  • Preserve the existing warning text when no DLL context is available.

Motivation

Instruction rebuilding failures previously reported only the hook address, making it difficult to identify which extension supplied the problematic hook. The additional DLL context makes these diagnostics actionable and simplifies troubleshooting faulty hooks.

@github-actions

github-actions Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Belonit
Belonit force-pushed the diagnostics/report-hook-dll branch from c78677e to 95dcf19 Compare October 20, 2026 20:50
@Metadorius
Metadorius merged commit 6247073 into master Oct 20, 2026
2 checks passed
@Belonit
Belonit deleted the diagnostics/report-hook-dll branch October 20, 2026 20:54
@Belonit

Belonit commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants